From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B012EDED for ; Tue, 28 Aug 2018 18:54:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2018 09:54:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,300,1531810800"; d="scan'208";a="65839968" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga007.fm.intel.com with ESMTP; 28 Aug 2018 09:54:35 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by IRSMSX151.ger.corp.intel.com ([169.254.4.94]) with mapi id 14.03.0319.002; Tue, 28 Aug 2018 17:54:34 +0100 From: "Van Haaren, Harry" To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= , "Power, Ciara" CC: "Archbold, Brian" , "Kenny, Emma" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure Thread-Index: AQHUOtoEXDtlvjLRJkGIcpB5svJvXaTVAxGAgABlnQA= Date: Tue, 28 Aug 2018 16:54:33 +0000 Message-ID: References: <1535026093-101872-1-git-send-email-ciara.power@intel.com> <1535026093-101872-2-git-send-email-ciara.power@intel.com> <20180828114633.vky27x53tu7eyag2@bidouze.vm.6wind.com> In-Reply-To: <20180828114633.vky27x53tu7eyag2@bidouze.vm.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWU1NjJhMzMtNDEzYS00ZDM4LTk2ZWYtODU0YjU5ZWU5N2QyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYUx6emdrVmMzaHdDeVZva1o3c0lKdTFJbW9wTSsrXC9XNHFnUVpyRkRsbElYVmZrZ1o2dG5jNXBcL3JYRXp4Mk1mIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2018 16:54:46 -0000 Hi Gaetan, > -----Original Message----- > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Tuesday, August 28, 2018 12:47 PM > To: Power, Ciara > Cc: Van Haaren, Harry ; Archbold, Brian > ; Kenny, Emma ; dev@dpdk.= org > Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry > infrastructure >=20 > Hi Ciara, >=20 > On Thu, Aug 23, 2018 at 01:08:03PM +0100, Ciara Power wrote: > > This patch adds the infrastructure and initial code for the > > telemetry library. > > > > A virtual device is used for telemetry, which is included in > > this patch. To use telemetry, a command-line argument must be > > used - "--vdev=3Dtelemetry". > > >=20 > Why use a virtual device? >=20 > It seems that you are only using the device semantic as a way to carry > around a tag telling the DPDK framework to init your library once it has > finished its initialization. >=20 > I guess you wanted to avoid having to add the call to rte_telemetry_init > to all applications. In the absence of a proper EAL option framework, > you can workaround by adding a --telemetry EAL parameter, setting a flag > on, and checking this flag from librte_telemetry, within a routine > declared with RTE_INIT_PRIO. I suppose that an EAL --flag could work too, it would mean that EAL would depend on this library. The --vdev trick keeps the library standalone. I don't have a strong opinion either way. :) > I only see afterward the selftest being triggered via kvargs. I haven't > yet looked at the testing done, but if it is only unit test, the "test" > app would be better suited. If it is integration testing to verify the > behavior of the library with other PMDs, you probably need specific > context, thus selftest being insufficient on its own and useless for > other users. Correct, self tests are triggered by kvargs. This same model is used in eg: eventdev PMDs to run selftests, where the tests are pretty complex and specific to the device under test. Again, I don't have a strong opinion but I don't see any issue with it being included in the vdev / telemetry library. We could write a shim test that the "official" test binary runs the telemetry tests if that is your concern? > > Control threads are used to get CPU cycles for telemetry, which > > are configured in this patch also. > > > > Signed-off-by: Ciara Power > > Signed-off-by: Brian Archbold >=20 > Regards, > -- > Ga=EBtan Rivet > 6WIND Thanks for review, and there's a lightning talk at Userspace so please do provide input there too :) -Harry