From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7E4B74C95 for ; Tue, 16 Oct 2018 02:45:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2018 17:45:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,386,1534834800"; d="scan'208";a="100528087" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga002.jf.intel.com with ESMTP; 15 Oct 2018 17:45:39 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 16 Oct 2018 01:45:38 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.67]) by IRSMSX156.ger.corp.intel.com ([169.254.3.178]) with mapi id 14.03.0319.002; Tue, 16 Oct 2018 01:45:38 +0100 From: "Van Haaren, Harry" To: "Laatz, Kevin" , "dev@dpdk.org" CC: "stephen@networkplumber.org" , "gaetan.rivet@6wind.com" , "shreyansh.jain@nxp.com" , "thomas@monjalon.net" , "mattias.ronnblom@ericsson.com" , "Richardson, Bruce" , Ciara Power , Brian Archbold Thread-Topic: [PATCH v4 04/13] telemetry: add initial connection socket Thread-Index: AQHUYYOy+0C22NegVUWLb4SfzC7c+aUhDu2A Date: Tue, 16 Oct 2018 00:45:37 +0000 Message-ID: References: <20181010105134.48079-1-kevin.laatz@intel.com> <20181011165837.81030-1-kevin.laatz@intel.com> <20181011165837.81030-5-kevin.laatz@intel.com> In-Reply-To: <20181011165837.81030-5-kevin.laatz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDZhODgwOTYtNjliNS00Nzg2LWFkZDEtOWJkYWMwMmZjMDFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK1VlMTR4a212cnBiWUsyS2EwZlpWQVRidkFyVFY0cWlzanhKeTh2TkpnKzlsa3dianhFdDVUZDFiS1VwMVRJWCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 04/13] telemetry: add initial connection socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 00:45:43 -0000 > -----Original Message----- > From: Laatz, Kevin > Sent: Thursday, October 11, 2018 9:58 AM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; > stephen@networkplumber.org; gaetan.rivet@6wind.com; shreyansh.jain@nxp.co= m; > thomas@monjalon.net; mattias.ronnblom@ericsson.com; Richardson, Bruce > ; Ciara Power ; Brian > Archbold ; Laatz, Kevin > Subject: [PATCH v4 04/13] telemetry: add initial connection socket >=20 > From: Ciara Power >=20 > This patch adds the telemetry UNIX socket. It is used to > allow connections from external clients. >=20 > On the initial connection from a client, ethdev stats are > registered in the metrics library, to allow for their retrieval > at a later stage. >=20 > Signed-off-by: Ciara Power > Signed-off-by: Brian Archbold > Signed-off-by: Kevin Laatz > --- > +static int32_t > +rte_telemetry_create_socket(struct telemetry_impl *telemetry) > +{ > + int ret; > + struct sockaddr_un addr =3D {0}; > + char socket_path[BUF_SIZE]; BUF_SIZE is not yet defined - it is in the next patch. Pull the #define back into this patchset; now this patch (without next one applied) won't build. With that fix; Acked-by: Harry van Haaren