From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <harry.van.haaren@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 510011B0FA for <dev@dpdk.org>; Wed, 17 Oct 2018 16:57:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 07:57:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,392,1534834800"; d="scan'208";a="272102517" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga005.fm.intel.com with ESMTP; 17 Oct 2018 07:57:38 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.67]) by IRSMSX151.ger.corp.intel.com ([169.254.4.71]) with mapi id 14.03.0319.002; Wed, 17 Oct 2018 15:57:37 +0100 From: "Van Haaren, Harry" <harry.van.haaren@intel.com> To: "dev@dpdk.org" <dev@dpdk.org> CC: "Byrne, Stephen1" <stephen1.byrne@intel.com>, "Varghese, Vipin" <vipin.varghese@intel.com> Thread-Topic: [PATCH] examples/service_cores: check lcores before test run Thread-Index: AQHUYi3853m/Er2BLE+LfCrf5+BhKqUjjtcw Date: Wed, 17 Oct 2018 14:57:37 +0000 Message-ID: <E923DB57A917B54B9182A2E928D00FA65E2EEBE5@IRSMSX102.ger.corp.intel.com> References: <20181012131403.36566-1-vipin.varghese@intel.com> In-Reply-To: <20181012131403.36566-1-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTRjYjNmNTMtNjNiOS00MmVmLTk2ZTktNGY3NzQ1YThlMTdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib09JU21XTHBTTjRzMHZwZEVwNWJyUFlVeXlGRCtOSGFubTlyNFhDdGk2VkxpSDB3RVwvblJpWjB6SkZlTW9xdlkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/service_cores: check lcores before test run X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 17 Oct 2018 14:57:40 -0000 > -----Original Message----- > From: Varghese, Vipin > Sent: Friday, October 12, 2018 6:14 AM > To: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com> > Cc: Byrne, Stephen1 <stephen1.byrne@intel.com>; Varghese, Vipin > <vipin.varghese@intel.com> > Subject: [PATCH] examples/service_cores: check lcores before test run >=20 > The service core samples has varied profiles created to run on specified > lcore count. The patch adds the check before each run, to ensure > example has sufficent lcores to be added as service cores on given run > profile. If sufficent cores are not found, the run is skipped with user > notification. >=20 > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> > --- The +1 feels weird, but given there's a core offset of 1 above, this seems like the best solution: Acked-by: Harry van Haaren <harry.van.haaren@intel.com>