From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id ACD325B16 for ; Mon, 21 Jan 2019 12:44:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2019 03:44:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,503,1539673200"; d="scan'208";a="268718566" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga004.jf.intel.com with ESMTP; 21 Jan 2019 03:44:05 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.65]) by IRSMSX151.ger.corp.intel.com ([169.254.4.172]) with mapi id 14.03.0415.000; Mon, 21 Jan 2019 11:43:59 +0000 From: "Van Haaren, Harry" To: "Rao, Nikhil" CC: "dev@dpdk.org" Thread-Topic: [PATCH] service: fix parameter type Thread-Index: AQHUr/+Qe3h3zeAZU0eLktv3MhptiqW5nMog Date: Mon, 21 Jan 2019 11:43:59 +0000 Message-ID: References: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com> In-Reply-To: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODQ3OWMzOWItMGY3ZC00MGE0LTkwYjYtZTJlODNiZjM3YWFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSW1jcU9MNGhGZ1hacHhXcG9JeUtJeHNsK0RjSUlKa2FmbEc1K2gwaFJvUkUyZTdrcFdGa3d2c1BJS2owY29nayJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] service: fix parameter type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 11:44:07 -0000 > -----Original Message----- > From: Rao, Nikhil > Sent: Saturday, January 19, 2019 2:01 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Rao, Nikhil > Subject: [PATCH] service: fix parameter type >=20 > The type of value parameter to rte_service_attr_get > should be uint64_t *, since the attributes > are of type uint64_t. >=20 > Fixes: 4d55194d76a4 ("service: add attribute get function") >=20 > Reviewed-by: Gage Eads > Signed-off-by: Nikhil Rao Acked-by: Harry van Haaren > --- > lib/librte_eal/common/include/rte_service.h | 2 +- > lib/librte_eal/common/rte_service.c | 2 +- > test/test/test_service_cores.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > For 19.02, I assume this will require the ABI change announcement. I will > post it once this patch is acked. Correct - this breaks API and ABI, so certainly will need an announce. Thanks for the fixup, -Harry