From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <harry.van.haaren@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DCC576904 for <dev@dpdk.org>; Wed, 13 Feb 2019 20:16:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2019 11:16:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,366,1544515200"; d="scan'208";a="117670917" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga008.jf.intel.com with ESMTP; 13 Feb 2019 11:16:26 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.219]) by IRSMSX154.ger.corp.intel.com ([169.254.12.219]) with mapi id 14.03.0415.000; Wed, 13 Feb 2019 19:16:25 +0000 From: "Van Haaren, Harry" <harry.van.haaren@intel.com> To: Michael Santana <msantana@redhat.com>, "dev@dpdk.org" <dev@dpdk.org> CC: Thomas Monjalon <thomas@monjalon.net> Thread-Topic: [dpdk-dev] [PATCH 1/2] Enable codespell from config file. Thread-Index: AQHUw8+LmKp7Ueew3kODgrUAabtIhKXeGMcw Date: Wed, 13 Feb 2019 19:16:24 +0000 Message-ID: <E923DB57A917B54B9182A2E928D00FA6757E08A6@IRSMSX102.ger.corp.intel.com> References: <20190213190813.12702-1-msantana@redhat.com> <20190213190813.12702-2-msantana@redhat.com> In-Reply-To: <20190213190813.12702-2-msantana@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2U3ZTljY2QtNzhhYy00Y2UyLTgwMGYtZjY3MDhmM2M5YTYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaHIzb09QcjNFYXNjZkhjanoyRGVcL1F5amc5RFA3SHNmRnh6NVQ5UURaZW9nN01NcW1WclBEWlRJZlE0NlwvNHU3In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] Enable codespell from config file. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 13 Feb 2019 19:16:29 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Santana > Sent: Wednesday, February 13, 2019 7:08 PM > To: dev@dpdk.org > Cc: Thomas Monjalon <thomas@monjalon.net> > Subject: [dpdk-dev] [PATCH 1/2] Enable codespell from config file. >=20 > Enable turning on codespell from any of the config files for > checkpatches.sh. codespell is a feature by checkpatch.pl that > checks for common spelling mistakes in comments in patches. >=20 > This feature is disabled by default. To enable it one must add > the '--codespell' flag to the $options variable in > checkpatches.sh. With this change the user can decide to turn > on codespell from a config file rather than directly modifying > checkpatches.sh >=20 > Signed-off-by: Michael Santana <msantana@redhat.com> Oh nice, I didn't know checkpatch had a spell check available. Would it make sense to turn on automatically if the required spelling progr= am is available? (Perhaps provide an explicit disable if certain people hate the idea..) I'm a +1 for tools just doing the right thing by default :) -H