Re: [dpdk-dev] [PATCH v5 00/15] A new net PMD - hinic

["Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions)" <xuanziyang2@huawei.com>]

> On 6/19/2019 4:45 PM, Ziyang Xuan wrote:
> > This patch set adds support of a new net PMD for Huawei Intelligent
> > nic. This patch provides supoort for basic RX/TX and the contorl path
> > needed for it.
> > Later on new features will be added like VLAN, VFs, etc.
> >
> > Basic features:
> > 1. Basic device operations: probe, initialization, start/stop,
> >    configure, info get.
> > 2. RX/TX queue operations: setup/release, start/stop.
> > 3. RX/TX.
> >
> > Stats:
> > 1. statistics and extended  statistics.
> >
> > ---
> > v2:
> >  - Fix arm64 compilation issue.
> >  - Fix some checkpatch checks issues
> >  - Fix patches thread issue.
> >  - Fit to the newest rte_ prefix patch
> >
> > v3:
> >  - Remove Rami from hinic pmd maintainers
> >  - Remove hinic_logs.* files and move log codes to other files
> >  - Remove the C++ guards within hinic pmd codes
> >  - Remove variable related errors shields from compilation files
> >  - Use lib link statu related functions but selfdefined
> >  - Fix x86_64-native-linuxapp-clang compilation errors
> >  - Fix i686-native-linuxapp-gcc compilation errors
> >
> > v4:
> >  - Update doc hinic.ini and hinic.rst
> >  - Remove x86-32, i686, BSD, Power8, ARMv7 compilations
> >  - Fit to newest IPV4 and IPV6 uppercase
> >
> > v5:
> >  - Update doc hinic.rst and release_19_08.rst
> >  - Delete unused codes
> >  - Optimize arch of codes and delete unnecessary files
> >  - Remove rte_panic
> >  - Subdivided patches
> >
> > Ziyang Xuan (15):
> >   net/hinic/base: add HW registers definition
> >   net/hinic/base: add HW interfaces of bar operation
> >   net/hinic/base: add api command channel code
> >   net/hinic/base: add support for cmdq mechanism
> >   net/hinic/base: add eq mechanism function code
> >   net/hinic/base: add mgmt module function code
> >   net/hinic/base: add code about hardware operation
> >   net/hinic/base: add nic business configurations
> >   net/hinic/base: add context and work queue support
> >   net/hinic: add various headers
> >   net/hinic: add hinic PMD build and doc files
> >   net/hinic: add device initailization
> >   net/hinic: add start stop close queue ops
> >   net/hinic: add tx/rx package burst
> >   net/hinic: add rss stats promisc ops
> 
> Hi Ziyang,
> 
> I put a few minor comments on patches, other than those looks good.
> 
> Also can you please run "./devtools/check-git-log.sh", I think it will give some
> warnings on commit log syntax, can you please check them?
> 
> Thanks,
> ferruh

Hi Feruh,

Before sending the patches, I always run the " ./devtools/checkpatches.sh "
and "./devtools/check-git-log.sh" to check the patches. There are not errors/warnings.

The following is the result of "./devtools/check-git-log.sh" checking:

root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0000-cover-letter.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0001-net-hinic-base-add-HW-registers-definition.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0002-net-hinic-base-add-HW-interfaces-of-bar-operation.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0003-net-hinic-base-add-api-command-channel-code.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0004-net-hinic-base-add-support-for-cmdq-mechanism.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0005-net-hinic-base-add-eq-mechanism-function-code.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0006-net-hinic-base-add-mgmt-module-function-code.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0007-net-hinic-base-add-code-about-hardware-operation.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0008-net-hinic-base-add-nic-business-configurations.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0009-net-hinic-base-add-context-and-work-queue-support.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0010-net-hinic-add-various-headers.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0011-net-hinic-add-hinic-PMD-build-and-doc-files.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0012-net-hinic-add-device-initailization.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0013-net-hinic-add-start-stop-close-queue-ops.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0014-net-hinic-add-tx-rx-package-burst.patch
root@tester_149:/home/william_xuan/patch/dpdk-next-net#./devtools/check-git-log.sh v5-0015-net-hinic-add-rss-stats-promisc-ops.patch

Best Regards,
Ziyang Xuan