From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCB8DA0471 for ; Thu, 18 Jul 2019 16:06:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8977E1041; Thu, 18 Jul 2019 16:06:23 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D8B7E160 for ; Thu, 18 Jul 2019 16:06:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 07:06:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,278,1559545200"; d="scan'208";a="162081659" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga008.jf.intel.com with ESMTP; 18 Jul 2019 07:06:19 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.40]) by IRSMSX154.ger.corp.intel.com ([169.254.12.160]) with mapi id 14.03.0439.000; Thu, 18 Jul 2019 15:06:19 +0100 From: "Lipiec, Herakliusz" To: Thomas Monjalon CC: "dev@dpdk.org" , "Richardson, Bruce" Thread-Topic: [PATCH] mk: fix output directory name when compiling with custom kernel header dir Thread-Index: AQHVPWykMttRqgemnUmrs2pympfJcKbQUhKAgAAWcIA= Date: Thu, 18 Jul 2019 14:06:18 +0000 Message-ID: References: <20190718132912.28250-1-herakliusz.lipiec@intel.com> <1936270.iUgZ9rBI3k@xps> In-Reply-To: <1936270.iUgZ9rBI3k@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGEyNzUxZTItYjE4YS00MTk2LWJjYmMtZDc2NDJhZThlYzdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRHJOd0I1Z3NQd3hLWVFwYmpnXC9BbXhyek9MYXFYWnU0OW9ibDBcL2M2U1lFRGkzSiswcVwvalNDVDVGa2xDUFU0dyJ9 x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, July 18, 2019 2:44 PM > 18/07/2019 15:29, Herakliusz Lipiec: > > When building dpdk with differnt kernel headers by specifying > > RTE_KERNELDIR igb_uio is compiled to directory with a name of the > > version of kernel thats running on the system instead of the one that > > dpdk is actually compiled against. Fixed by replacing hardcoded value > > with value from RTE_KERNELDIR. > > > > Cc: stable@intel.com > > Cc: bruce.richardson@intel.com > > Signed-off-by: Herakliusz Lipiec > > --- > > --- a/mk/rte.sdkinstall.mk > > +++ b/mk/rte.sdkinstall.mk > > ifeq ($(RTE_EXEC_ENV),linux) > > -kerneldir ?=3D /lib/modules/$(shell uname -r)/extra/dpdk > > +kerneldir ?=3D $(subst /build,/extra/dpdk,$(RTE_KERNELDIR)) > > else > > kerneldir ?=3D /boot/modules > > endif >=20 > You are changing the alignment :) >=20 > This change is only for the "make" system. > How does it work for meson? >=20 >=20 The issue doesn't seem to be happening when using meson build system, kernel modules are compiled into correct directory.=20