From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD085A0471 for ; Fri, 19 Jul 2019 13:09:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74CF4322C; Fri, 19 Jul 2019 13:09:31 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3BA4D2C17; Fri, 19 Jul 2019 13:09:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 04:09:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,282,1559545200"; d="scan'208";a="343662646" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga005.jf.intel.com with ESMTP; 19 Jul 2019 04:09:27 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.40]) by IRSMSX101.ger.corp.intel.com ([169.254.1.88]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 12:09:26 +0100 From: "Lipiec, Herakliusz" To: Thomas Monjalon CC: "dev@dpdk.org" , "stable@dpdk.org" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir Thread-Index: AQHVPWykMttRqgemnUmrs2pympfJcKbQV4sAgACMPwCAAOWhkA== Date: Fri, 19 Jul 2019 11:09:25 +0000 Message-ID: References: <20190718132912.28250-1-herakliusz.lipiec@intel.com> <20190718140330.43109-1-herakliusz.lipiec@intel.com> <1901807.fy38742gHy@xps> In-Reply-To: <1901807.fy38742gHy@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzU3NGM1YzYtMTM3YS00OWFhLWI3MzctNWFmNzE2ZGEyNjc2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiemdtcmdJa0QxMUVacVRjN0Z6U1NmWldSRnRTREI4ZFZnSmJVcnlKSXB3citBYjRySGxYMWFDNDVPQ1hsdXBNdiJ9 x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, July 18, 2019 11:25 PM > 18/07/2019 16:03, Herakliusz Lipiec: > > When building dpdk with differnt kernel headers by specifying > > RTE_KERNELDIR igb_uio is compiled to directory with a name of the > > version of kernel thats running on the system instead of the one that > > dpdk is actually compiled against. Fixed by replacing hardcoded value > > with value from RTE_KERNELDIR. >=20 > missing original commit reference: > Fixes: 3967af352aeb ("mk: install kernel modules") >=20 > > Cc: stable@dpdk.org > > Cc: bruce.richardson@intel.com > > Signed-off-by: Herakliusz Lipiec > > > > --- > > resending v1 with corrected cc address for stable and corrected > > alignment. >=20 > It should be marked v2, > and the alignment is still not correct. Sorry I forgot to add the change to commit, sending as v2. >=20 > > -kerneldir ?=3D /lib/modules/$(shell uname -r)/extra/dpdk > > +kerneldir ?=3D $(subst /build,/extra/dpdk,$(RTE_KERNELDIR)) >=20 > I would suggest another syntax, easier to read: >=20 > kerneldir ?=3D $(RTE_KERNELDIR:/build=3D/extra/dpdk) >=20 I have tried that before and it didn't seem to solve the issue.