From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40051.outbound.protection.outlook.com [40.107.4.51]) by dpdk.org (Postfix) with ESMTP id 7836D1B7A3 for ; Tue, 15 May 2018 20:38:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MbroU4Qpdp8Co9OHyX7tUjOpEqT5QLpE0yi80+vbs4Q=; b=WnXKrerLv39UiMguhcA+d9mxoKSIScxFJ3RZvKLzXcSfh2NQ3dmjSY8pSwhnWzR9YBTa9Ac7y0HLZi47zngmNrrxyNqfcV5CUbOtW3lFPF38+HVexJBzjNKtFlVqE0grP+I0gdpBom3CoOxU3mLlQyZaILGK2bFEwSbZv3Sv2KY= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB3598.eurprd05.prod.outlook.com (10.166.198.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Tue, 15 May 2018 18:38:35 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d%13]) with mapi id 15.20.0755.018; Tue, 15 May 2018 18:38:34 +0000 From: Yongseok Koh To: Sirshak Das CC: Gavin Hu , "dev@dpdk.org" , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" , Shahaf Shuler Thread-Topic: [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue Thread-Index: AQHT7C6E0b3pe6+RTUeSVUPHYaf+u6QxBYUAgAANOQCAAAy/gA== Date: Tue, 15 May 2018 18:38:34 +0000 Message-ID: References: <1526372924-28411-1-git-send-email-gavin.hu@arm.com> <1526376227-25534-1-git-send-email-gavin.hu@arm.com> <1526376227-25534-2-git-send-email-gavin.hu@arm.com> <87zi10rekn.fsf@arm.com> In-Reply-To: <87zi10rekn.fsf@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB3598; 7:HRizKATD/WP6Cl7l6WJoYp7/Ly24dxbfzKFrhkggFmHrNVIonZN1YLt/W/pw11oqSfCI9JrQNN3nMz5YoVqMzePDBUi8IFVQgY7FLi9ooJlEiTYCcvik6SAHwOda7uLcF4xdiMUAMPtHv0wRjLS4UKxMZhqgew4Cjb9173vzqClj94n8DWGQA7i3DcnsmqmHqWaYUxD7KotIUJeKMyf6slvs0iyqQ4Hncb0wzRJyNTh4xNAuw0mOPXxi7E0RWYvM x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB3598; x-ms-traffictypediagnostic: VI1PR0501MB3598: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR0501MB3598; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB3598; x-forefront-prvs: 0673F5BE31 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(39380400002)(396003)(39860400002)(199004)(189003)(6436002)(54906003)(6512007)(478600001)(25786009)(229853002)(81156014)(3660700001)(105586002)(5250100002)(81166006)(8676002)(8936002)(97736004)(93886005)(316002)(6916009)(6486002)(82746002)(106356001)(4326008)(33656002)(53936002)(476003)(6506007)(6246003)(99286004)(2906002)(66066001)(107886003)(3846002)(2616005)(486006)(53546011)(83716003)(14454004)(76176011)(446003)(86362001)(68736007)(36756003)(102836004)(5660300001)(2900100001)(11346002)(305945005)(26005)(7736002)(3280700002)(345774005)(186003)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB3598; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 2OwWag2WJkkwGsqqIYYBtdZFNnhNCBILUb7qsziSYUc8j1gVyZY8TOzmnDVvkea2dRaCzhtIym/dEV6CZQxjGVKOQlb4nedQXDqicxkl9wT3nkfZlOoumee5iCmCxfSlwE2IcQgYRn4SY58lWq1RcornU8iFnVrzRWtkJ2CrA9dk9yv0fVzo5DDvYTe3HKqQ spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <8ED6F2B9694F3B4EABB6E860F32E20F2@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 88b7fd5d-6642-4119-5e6c-08d5ba9310e1 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88b7fd5d-6642-4119-5e6c-08d5ba9310e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2018 18:38:34.7863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB3598 Subject: Re: [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 18:38:36 -0000 > On May 15, 2018, at 10:52 AM, Sirshak Das wrote: >=20 > Hi Yongseok, >=20 > We will make the commit message more verbose. > As for the error: This is a clang compiler issue: > drivers/net/mlx5/mlx5_rxtx_vec.c:37: > /home/sirdas/code/commitc/dpdk-stable-18.02.1/drivers/net/mlx5/mlx5_rxtx_= vec_neon.h:170:24: error: too many arguments provided to function-like macr= o invocation > (uint16x8_t) { 0, 0, cs_flags, > rte_cpu_to_be_16(len), Thanks for explanation. Please add my acked-by tag when you submit the new version with a) title change b) verbose commit message. Acked-by: Yongseok Koh =20 Thank you for contribution! Yongseok > Yongseok Koh writes: >=20 >>> On May 15, 2018, at 2:23 AM, Gavin Hu wrote: >>=20 >> The title should start from 'net/mlx5: ...' and please be more specific = why >> that pair of parentheses is needed. Add more commit messages and it'd be >> better to add the error messages like you do in the other commit. >>=20 >> To me, it still looks unnecessary. >>=20 >> Thanks, >> Yongseok >>=20 >>> Signed-off-by: Gavin Hu >>> Signed-off-by: Sirshak Das >>> Reviewed-by: Phil Yang >>> Reviewed-by: Honnappa Nagarahalli >>> --- >>> drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >>>=20 >>> diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/m= lx5_rxtx_vec_neon.h >>> index 2673d6b..71a5eaf 100644 >>> --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h >>> +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h >>> @@ -167,8 +167,8 @@ txq_scatter_v(struct mlx5_txq_data *txq, struct rte= _mbuf **pkts, >>> vst1q_u8((void *)t_wqe, ctrl); >>> /* Fill ESEG in the header. */ >>> vst1q_u16((void *)(t_wqe + 1), >>> - (uint16x8_t) { 0, 0, cs_flags, rte_cpu_to_be_16(len), >>> - 0, 0, 0, 0 }); >>> + ((uint16x8_t) { 0, 0, cs_flags, rte_cpu_to_be_16(len), >>> + 0, 0, 0, 0 })); >>> txq->wqe_ci =3D wqe_ci; >>> } >>> if (!n) >>> @@ -300,10 +300,10 @@ txq_burst_v(struct mlx5_txq_data *txq, struct rte= _mbuf **pkts, uint16_t pkts_n, >>> vst1q_u8((void *)t_wqe, ctrl); >>> /* Fill ESEG in the header. */ >>> vst1q_u8((void *)(t_wqe + 1), >>> - (uint8x16_t) { 0, 0, 0, 0, >>> - cs_flags, 0, 0, 0, >>> - 0, 0, 0, 0, >>> - 0, 0, 0, 0 }); >>> + ((uint8x16_t) { 0, 0, 0, 0, >>> + cs_flags, 0, 0, 0, >>> + 0, 0, 0, 0, >>> + 0, 0, 0, 0 })); >>> #ifdef MLX5_PMD_SOFT_COUNTERS >>> txq->stats.opackets +=3D pkts_n; >>> #endif >>> --=20 >>> 2.1.4 >>>=20 >=20