From: Yong Wang <yongwang@vmware.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity
Date: Thu, 31 Mar 2016 17:50:01 +0000 [thread overview]
Message-ID: <ED11145B-051C-45EF-9DC1-9D6A50BCF24E@vmware.com> (raw)
In-Reply-To: <1459373905-10296-1-git-send-email-stephen@networkplumber.org>
On 3/30/16, 2:38 PM, "Stephen Hemminger" <stephen@networkplumber.org> wrote:
>These asserts are only for debugging and never fired during
>any testing, but they confuse coverity's null tracking.
>
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>---
Acked-by: Yong Wang <yongwang@vmware.com>
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
>index 66b0eed..f72156a 100644
>--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
>+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
>@@ -710,7 +710,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
> * the last mbuf of the current packet.
> */
> if (rcd->sop) {
>- VMXNET3_ASSERT(rxq->start_seg != NULL);
> VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_HEAD);
>
> if (unlikely(rcd->len == 0)) {
>@@ -729,7 +728,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
> struct rte_mbuf *start = rxq->start_seg;
>
> VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);
>- VMXNET3_ASSERT(start != NULL);
>
> start->pkt_len += rxm->data_len;
> start->nb_segs++;
>--
>2.1.4
>
next prev parent reply other threads:[~2016-03-31 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 21:38 Stephen Hemminger
2016-03-31 17:50 ` Yong Wang [this message]
2016-03-31 19:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED11145B-051C-45EF-9DC1-9D6A50BCF24E@vmware.com \
--to=yongwang@vmware.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).