From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76]) by dpdk.org (Postfix) with ESMTP id 5AE885596 for ; Sat, 16 Jul 2016 13:14:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1539; q=dns/txt; s=iport; t=1468667695; x=1469877295; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=eY3uT8qhgU/RGKPqA1e+C+LCCmK9zOpUZgZ2zlpc9N8=; b=hrJyy+cIr2cAtkcxOu0cyX9XFncgMVbBeWjFkRxDCmYSSSH35deE2hwH 7jlMNt/loguXk5Nt7Wu9vqkGqxQBZutnSjCGohs0xovT5by95Ge84tp1R h0lkULt6QyTxpwWJnAdb/aEt41uzKeKVk5Ftd9EqwJz20sJ+0fj4KoIXV I=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AVAgCYFopX/5pdJa1cgz+BUga4coF5h?= =?us-ascii?q?hoCgSk4FAEBAQEBAQFlJ4RcAQEEATo/BQsCAQgYHhAyJQIEDgWIKAi9MQEBAQE?= =?us-ascii?q?BAQEBAQEBAQEBAQEBAQEBHYYqgXiCVYRAgyyCEh0BBJNjhUEBjl4KjyyQHQEeN?= =?us-ascii?q?oNzboZkfwEBAQ?= X-IronPort-AV: E=Sophos;i="5.28,373,1464652800"; d="scan'208";a="126716368" Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by rcdn-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2016 11:14:54 +0000 Received: from XCH-RCD-001.cisco.com (xch-rcd-001.cisco.com [173.37.102.11]) by rcdn-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id u6GBEr7f015594 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Sat, 16 Jul 2016 11:14:54 GMT Received: from xch-aln-005.cisco.com (173.36.7.15) by XCH-RCD-001.cisco.com (173.37.102.11) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Sat, 16 Jul 2016 06:14:53 -0500 Received: from xch-aln-005.cisco.com ([173.36.7.15]) by XCH-ALN-005.cisco.com ([173.36.7.15]) with mapi id 15.00.1210.000; Sat, 16 Jul 2016 06:14:53 -0500 From: "Damjan Marion (damarion)" To: Thomas Monjalon CC: Jan Viktorin , "dev@dpdk.org" , Bruce Richardson , Konstantin Ananyev , David Marchand Thread-Topic: [dpdk-dev] spinlock: Move constructor function out of header file Thread-Index: AQHR3foM8k8goj5lX0KBo8A7CRZtGKAZ1AsAgAAIgoCAAWHUgA== Date: Sat, 16 Jul 2016 11:14:53 +0000 Message-ID: References: <20160714132729.27024-1-damarion@cisco.com> <20160714200336.119bcfce@jvn> <3850930.xJZUcGIqBK@xps13> <2290419.B64Si7jFuQ@xps13> In-Reply-To: <2290419.B64Si7jFuQ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.61.242.202] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] spinlock: Move constructor function out of header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jul 2016 11:14:55 -0000 > On 15 Jul 2016, at 17:08, Thomas Monjalon wro= te: >=20 > 2016-07-15 16:37, Thomas Monjalon: >> I will apply it with trivial changes suggested by Jan and >> the small needed changes that I describe below: >>=20 >> 2016-07-14 20:03, Jan Viktorin: >>> On Thu, 14 Jul 2016 15:27:29 +0200 >>> damarion@cisco.com wrote: >>>> --- /dev/null >>>> +++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c >> [...] >>>> +uint8_t rte_rtm_supported; /* cache the flag to avoid the overhead >>>> + of the rte_cpu_get_flag_enabled function */ >>=20 >> This variable must be exported in the .map file. >>=20 >>>> --- a/lib/librte_eal/linuxapp/eal/Makefile >>>> +++ b/lib/librte_eal/linuxapp/eal/Makefile >>>> @@ -106,6 +106,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) +=3D rte_keep= alive.c >>>>=20 >>>> # from arch dir >>>> SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) +=3D rte_cpuflags.c >>>> +SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) +=3D rte_spinlock.c >>>=20 >>> This is not good, you provide rte_spinlock.c only for x86. Building >>> for any other arch would fail to find this file. >>=20 >> This change do the trick: >>=20 >> -SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) +=3D rte_spinlock.c >> +SRCS-$(CONFIG_RTE_ARCH_X86) +=3D rte_spinlock.c >>=20 >> (Note that CONFIG_RTE_EXEC_ENV_LINUXAPP check is not needed inside linux= app EAL) >>=20 >>> Moreover, the bsdapp/eal/Makefile should reflect this situation as >>> well. >>=20 >> Yes >=20 > Applied with above changes, thanks Thanks!=