From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1E55B593A for ; Thu, 5 May 2016 06:52:02 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 04 May 2016 21:52:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,580,1455004800"; d="scan'208";a="97540484" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 04 May 2016 21:52:03 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 4 May 2016 21:52:01 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 4 May 2016 21:52:01 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.58]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.148]) with mapi id 14.03.0248.002; Thu, 5 May 2016 12:51:59 +0800 From: "Tan, Jianfeng" To: Yuanhan Liu CC: "dev@dpdk.org" , "Xie, Huawei" Thread-Topic: [dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue memzones Thread-Index: AQHRobDrFCSKdrVRKEOtEOJLNKChkp+f57oAgAlK+wCAAJ1JQA== Date: Thu, 5 May 2016 04:51:59 +0000 Message-ID: References: <1461673932-128879-1-git-send-email-jianfeng.tan@intel.com> <1461890926-16727-1-git-send-email-jianfeng.tan@intel.com> <1461890926-16727-3-git-send-email-jianfeng.tan@intel.com> <20160429053308.GC5641@yliu-dev.sh.intel.com> <20160505032750.GW5641@yliu-dev.sh.intel.com> In-Reply-To: <20160505032750.GW5641@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue memzones X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 04:52:03 -0000 Hi Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Thursday, May 5, 2016 11:28 AM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Xie, Huawei > Subject: Re: [dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtque= ue > memzones >=20 > ping... >=20 > On Thu, Apr 28, 2016 at 10:33:08PM -0700, Yuanhan Liu wrote: > > On Fri, Apr 29, 2016 at 12:48:46AM +0000, Jianfeng Tan wrote: > > > @@ -447,6 +453,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev > *dev, > > > > > > hw->vtpci_ops->setup_queue(hw, vq); > > > > > > + vq->started =3D 1; > > > > Judging that this is in the "_queue_setup" stage, and we have another > > stage called "_dev_start", naming it to "started" seems confusing then. > > > > So, how about naming it to something like "configured"? Besides that, > > this patch set looks good to me. If you agree the name change, or have > > better idea, I could fix it while applying it. Yes, I agree _configured_ would be better. Thanks, Jianfeng=20 > > > > --yliu