From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 934B25A66 for ; Mon, 9 May 2016 09:58:30 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 09 May 2016 00:58:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,600,1455004800"; d="scan'208";a="99687967" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 09 May 2016 00:58:30 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 9 May 2016 00:58:29 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.58]) by shsmsx102.ccr.corp.intel.com ([169.254.2.104]) with mapi id 14.03.0248.002; Mon, 9 May 2016 15:58:27 +0800 From: "Tan, Jianfeng" To: Yuanhan Liu CC: "dev@dpdk.org" , "Xie, Huawei" Thread-Topic: [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup() Thread-Index: AQHRobDpvTvYfopQ7EOTbTb3KBbE25+pMGKAgAcTIgA= Date: Mon, 9 May 2016 07:58:26 +0000 Message-ID: References: <1461673932-128879-1-git-send-email-jianfeng.tan@intel.com> <1461890926-16727-1-git-send-email-jianfeng.tan@intel.com> <1461890926-16727-2-git-send-email-jianfeng.tan@intel.com> <20160505031931.GV5641@yliu-dev.sh.intel.com> In-Reply-To: <20160505031931.GV5641@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2016 07:58:32 -0000 Hi Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Thursday, May 5, 2016 11:20 AM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Xie, Huawei > Subject: Re: [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup() >=20 > On Fri, Apr 29, 2016 at 12:48:45AM +0000, Jianfeng Tan wrote: > > + if (queue_type < VTNET_RQ || queue_type > VTNET_CQ) { > > + PMD_INIT_LOG(ERR, "invalid queue type: %d", queue_type); > > + return -EINVAL; > > } >=20 > I'm thinking this check is not necessary. We can make sure it's a valid > queue type. Yes, this is not necessary, and I was also entangled with whether to keep i= t or not. And ok, I'll send a new version with this check removed. Thanks, Jianfeng >=20 > --yliu