From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 760892617 for ; Fri, 1 Jul 2016 02:52:06 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 30 Jun 2016 17:52:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,554,1459839600"; d="scan'208";a="1013165243" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 30 Jun 2016 17:52:05 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 30 Jun 2016 17:52:04 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 30 Jun 2016 17:52:04 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.230]) with mapi id 14.03.0248.002; Fri, 1 Jul 2016 08:52:02 +0800 From: "Tan, Jianfeng" To: Thomas Monjalon CC: "dev@dpdk.org" , David Marchand , Panu Matilainen Thread-Topic: [dpdk-dev] [PATCH] eal: add option --avail-cores to detect lcores Thread-Index: AQHRdjg4fxsyxldi+k6BsJzCwq6SQp9OvcqAgAEYXwCAAL/5AIBt/f0AgAFq8YCAQjk+AIABP+rg Date: Fri, 1 Jul 2016 00:52:01 +0000 Message-ID: References: <1453661393-85704-1-git-send-email-jianfeng.tan@intel.com> <0f795ccf-838f-120e-84b2-81f69b279050@intel.com> <1672769.UR6W46hl4M@xps13> In-Reply-To: <1672769.UR6W46hl4M@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: add option --avail-cores to detect lcores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2016 00:52:06 -0000 Hi Thomas, > > > > > > Looking at your special case, if the user did set an isolcpus option > > > for another use, with no -c/-l, I understand the dpdk application > > > won't care too much about it. > > > So, this seems like somehow rude to the rest of the system and > unwanted. > > > > The case you mentioned above is not the case I mean. But you make your > > point about this one. > > The case I originally mean: user sets an isolcpus option for DPDK > > applications. Originally, DPDK apps would be started without any > > problem. But for now, fail to start them because the required cores are > > excluded before -c/-l. As per your comments following, we can add a > > warning message (or should we quit on this situation?). But it indeed > > has an effect on old users (they should changed to use "taskset > > ./dpdk_app ..."). Do you think it's a problem? >=20 > There is no activity on this patch. > Jianfeng, do not hesitate to ping if needed. > Should we class this patch as "changes requested"? Yes, according to latest comments, it should be classified as "changes requ= ested" (I've done that). I'll resent a new version. Thanks, Jianfeng