From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianfeng.tan@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id BF266558B
 for <dev@dpdk.org>; Tue,  5 Jul 2016 12:14:52 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga104.fm.intel.com with ESMTP; 05 Jul 2016 03:14:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,579,1459839600"; d="scan'208";a="1001159515"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by fmsmga001.fm.intel.com with ESMTP; 05 Jul 2016 03:14:51 -0700
Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 5 Jul 2016 03:14:51 -0700
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
 fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 5 Jul 2016 03:14:50 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by
 SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002;
 Tue, 5 Jul 2016 18:14:49 +0800
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Xie, Huawei" <huawei.xie@intel.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>, "Jastrzebski, MichalX K"
 <michalx.k.jastrzebski@intel.com>
Thread-Topic: [PATCH 1/4] net/virtio-user: fix return value not checked
Thread-Index: AQHR0eV4TW7GQOnMbU6F5vrOb+uXxqACUxKAgAdTjzA=
Date: Tue, 5 Jul 2016 10:14:28 +0000
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E3610614EA1@SHSMSX103.ccr.corp.intel.com>
References: <1467191137-65087-1-git-send-email-jianfeng.tan@intel.com>
 <1467191137-65087-2-git-send-email-jianfeng.tan@intel.com>
 <20160701021551.GP2831@yliu-dev.sh.intel.com>
In-Reply-To: <20160701021551.GP2831@yliu-dev.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/4] net/virtio-user: fix return value not
	checked
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2016 10:14:53 -0000

Hi Yuanhan,

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Friday, July 1, 2016 10:16 AM
> To: Tan, Jianfeng
> Cc: dev@dpdk.org; Xie, Huawei; Mcnamara, John
> Subject: Re: [PATCH 1/4] net/virtio-user: fix return value not checked
>=20
> On Wed, Jun 29, 2016 at 09:05:33AM +0000, Jianfeng Tan wrote:
> > -	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) =3D=3D 1)
> > -		rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
> > -				   &get_integer_arg, &cq);
> > +	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) =3D=3D 1) {
> > +		ret =3D rte_kvargs_process(kvlist,
> VIRTIO_USER_ARG_CQ_NUM,
> > +					 &get_integer_arg, &cq);
> > +		if (ret < 0) {
> > +			PMD_INIT_LOG(ERR, "error to parse %s",
> > +				     VIRTIO_USER_ARG_CQ_NUM);
> > +			goto end;
> > +		}
> > +	}
> >  	else if (queues > 1)
>=20
> Above 2 lines should be in one line. Fixed, and series applied to
> dpdk-next-virtio.

Thanks.

But there's another problem in the commit log: the Coverity defect ID shoul=
d be "127477, 127478"  instead of "127344, 127478". Can you please help mak=
e it right?

Thanks,
Jianfeng

>=20
> Thanks.
>=20
> 	--yliu