From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5FCBF5587 for ; Mon, 12 Sep 2016 10:42:59 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP; 12 Sep 2016 01:42:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,322,1470726000"; d="scan'208";a="7347041" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 12 Sep 2016 01:42:58 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 12 Sep 2016 01:42:58 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 12 Sep 2016 01:42:57 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.102]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.174]) with mapi id 14.03.0248.002; Mon, 12 Sep 2016 16:42:56 +0800 From: "Tan, Jianfeng" To: Yuanhan Liu CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "Wu, Jingjing" , "Kavanagh, Mark B" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on VXLAN failure Thread-Index: AQHR7iYYHqPS1AL8k0WaEzkOwM7UoaBz6C0AgAHeYxA= Date: Mon, 12 Sep 2016 08:42:55 +0000 Message-ID: References: <1470297529-100773-1-git-send-email-jianfeng.tan@intel.com> <1470297529-100773-2-git-send-email-jianfeng.tan@intel.com> <20160911120906.GV23158@yliu-dev.sh.intel.com> In-Reply-To: <20160911120906.GV23158@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on VXLAN failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 08:42:59 -0000 Hi Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Sunday, September 11, 2016 8:09 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Ananyev, Konstantin; Wu, Jingjing; Kavanagh, Mark B; > Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on > VXLAN failure >=20 > On Thu, Aug 04, 2016 at 07:58:48AM +0000, Jianfeng Tan wrote: > > Based on previous fix of offload on VXLAN using i40e, applications > > need to set proper tunneling type on ol_flags so that i40e driver > > can pass it to NIC. > > > > Fixes: a50245ede72a ("examples/tep_term: initialize VXLAN sample") > > > > Signed-off-by: Jianfeng Tan > > --- > > examples/tep_termination/vxlan.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/examples/tep_termination/vxlan.c > b/examples/tep_termination/vxlan.c > > index 5ee1f95..4bad33d 100644 > > --- a/examples/tep_termination/vxlan.c > > +++ b/examples/tep_termination/vxlan.c > > @@ -237,6 +237,8 @@ encapsulation(struct rte_mbuf *m, uint8_t > queue_id) > > m->outer_l2_len =3D sizeof(struct ether_hdr); > > m->outer_l3_len =3D sizeof(struct ipv4_hdr); > > > > + ol_flags |=3D PKT_TX_TUNNEL_VXLAN; > > + >=20 > Hi, >=20 > FYI, my testrobot caught some errors when this patch is applied. It's because this patch set has dependency on a previous patch set, which s= eems a difficult scenario to handle. There's no standard to state the depen= dency, right? Thanks, Jianfeng >=20 > --yliu >=20 > --- > x86_64-native-linuxapp-clang: config-all-yes > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > /root/dpdk/examples/tep_termination/vxlan.c:240:14: error: use of > undeclared identifier 'PKT_TX_TUNNEL_VXLAN' > ol_flags |=3D PKT_TX_TUNNEL_VXLAN; > ^ > 1 error generated. > make[1]: *** [vxlan.o] Error 1 > make: *** [all] Error 2 > error: build examples/tep_termination failed > error: build failed >=20 > ...