From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A8173569F for ; Fri, 23 Sep 2016 12:08:10 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 23 Sep 2016 03:08:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,381,1470726000"; d="scan'208";a="1055271498" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 23 Sep 2016 03:08:09 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 23 Sep 2016 03:08:09 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.234]) by shsmsx102.ccr.corp.intel.com ([169.254.2.15]) with mapi id 14.03.0248.002; Fri, 23 Sep 2016 18:08:06 +0800 From: "Tan, Jianfeng" To: Yuanhan Liu , Thomas Monjalon CC: "dev@dpdk.org" , David Marchand Thread-Topic: [PATCH] eal: remove single file segments related code Thread-Index: AQHSFXru9HHRtfuMn0i1qwpAx+wt/qCG2NtA Date: Fri, 23 Sep 2016 10:08:06 +0000 Message-ID: References: <1474614646-23648-1-git-send-email-yuanhan.liu@linux.intel.com> <3786074.FTf50R74LC@xps13> <20160923091448.GB23158@yliu-dev.sh.intel.com> In-Reply-To: <20160923091448.GB23158@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: remove single file segments related code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2016 10:08:11 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Friday, September 23, 2016 5:15 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; David Marchand; Tan, Jianfeng > Subject: Re: [PATCH] eal: remove single file segments related code >=20 > On Fri, Sep 23, 2016 at 10:50:06AM +0200, Thomas Monjalon wrote: > > 2016-09-23 15:10, Yuanhan Liu: > > > Commit c711ccb30987 ("ivshmem: remove library and its EAL integration= ") > > > removed ivshmem support, but seems David forgot to remove the another > > > piece of code: code for RTE_EAL_SINGLE_FILE_SEGMENTS, which is > introduced > > > when ivshmem was firstly added. > > > > It is not a mistake. We thought it is used by container use case. >=20 > I think no. It would help the container case a bit, but not too much I > would think, especially when the memory goes fragement. >=20 > Jianfeng, IIRC, you don't use that option for container case, right? >=20 > --yliu No, I don't use this option for container case. As yuanhan said, it cannot = provide much help for virtio_user memory region number limitation. Thanks, Jianfeng=20