From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A1BFC5A44 for ; Wed, 4 Jan 2017 08:30:40 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 03 Jan 2017 23:30:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,458,1477983600"; d="scan'208";a="209440307" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 03 Jan 2017 23:30:39 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Jan 2017 23:30:39 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Wed, 4 Jan 2017 15:30:38 +0800 From: "Tan, Jianfeng" To: Yuanhan Liu CC: "dev@dpdk.org" , "stephen@networkplumber.org" Thread-Topic: [PATCH v2 5/9] net/virtio: setup rxq interrupts Thread-Index: AQHSYaVqMJWiHRP1X0C9pU2ZE8FrYKEfgkWAgAhp4gD//4EuAIAAh/og Date: Wed, 4 Jan 2017 07:30:37 +0000 Message-ID: References: <1482996643-113253-1-git-send-email-jianfeng.tan@intel.com> <1482996643-113253-6-git-send-email-jianfeng.tan@intel.com> <20161230062747.GI21789@yliu-dev.sh.intel.com> <88093c9a-5bd8-5acb-aa87-4aa92c03a2df@intel.com> <20170104072256.GK21228@yliu-dev.sh.intel.com> In-Reply-To: <20170104072256.GK21228@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 5/9] net/virtio: setup rxq interrupts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 07:30:41 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Wednesday, January 4, 2017 3:23 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; stephen@networkplumber.org > Subject: Re: [PATCH v2 5/9] net/virtio: setup rxq interrupts >=20 > On Wed, Jan 04, 2017 at 02:56:50PM +0800, Tan, Jianfeng wrote: > > > > > > [...] > > >>+ > > >>+ if (virtio_queues_bind_intr(dev) < 0) { > > >>+ PMD_INIT_LOG(ERR, "Failed to bind queue/interrupt"); > > >>+ return -1; > > >You have to free intr_handle->intr_vec, otherwise, memory leak occurs. > > > > It's freed at dev_close(). Do you mean freeing and reallocating here? A= s >=20 > The typical way is free the resources have been allocated when errors > happens. >=20 > > nr_rx_queues is not a changeable value, I don't see the necessity here.= I > > miss something? >=20 > No. nb_rx_queues does change, when people reconfigure the queue > number. > However, the MAX queues the virito supports does not change. You could > use that number for allocation. Oh yes. I will fix it. Thanks, Jianfeng >=20 > --yliu