From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1FB7EFA52; Wed, 18 Jan 2017 14:49:33 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP; 18 Jan 2017 05:49:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,249,1477983600"; d="scan'208";a="55349643" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 18 Jan 2017 05:49:32 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Jan 2017 05:49:32 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Jan 2017 05:49:32 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Wed, 18 Jan 2017 21:49:30 +0800 From: "Tan, Jianfeng" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Liu, Yuanhan" , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name Thread-Index: AQHScYAXnxW03Xcmgk642i33+JZqX6E9maKAgACmPGA= Date: Wed, 18 Jan 2017 13:49:29 +0000 Message-ID: References: <1484739849-72803-1-git-send-email-jianfeng.tan@intel.com> <8fea300e-350e-6b83-a706-acadec98afc8@intel.com> In-Reply-To: <8fea300e-350e-6b83-a706-acadec98afc8@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 13:49:34 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, January 18, 2017 7:53 PM > To: Tan, Jianfeng; dev@dpdk.org > Cc: Liu, Yuanhan; stable@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver na= me >=20 > On 1/18/2017 11:44 AM, Jianfeng Tan wrote: > > API rte_eth_dev_info_get() fills driver name according to drv_name > > of rte_eth_dev_data. But we have not fill such info in virtio_user. > > > > We do not use the same one with virtio device as some applications > > might depend on driver name to differetiate kinds of devices, such > > as VPP. > > > > Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver") > > CC: stable@dpdk.org > > > > Signed-off-by: Jianfeng Tan > > --- > > drivers/net/virtio/virtio_user_ethdev.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/virtio/virtio_user_ethdev.c > b/drivers/net/virtio/virtio_user_ethdev.c > > index c877968..110f6a9 100644 > > --- a/drivers/net/virtio/virtio_user_ethdev.c > > +++ b/drivers/net/virtio/virtio_user_ethdev.c > > @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name) > > hw->use_simple_rxtx =3D 0; > > hw->virtio_user_dev =3D dev; > > data->dev_private =3D hw; > > + data->drv_name =3D "virtio_user PMD"; >=20 > How driver naming done changed in next-net. > Please check any other virtual driver in next-net for sample. Thank you for the info. And it seems that it's already fixed by that patch. Self NACK. Thanks, Jianfeng >=20 > > data->numa_node =3D SOCKET_ID_ANY; > > data->kdrv =3D RTE_KDRV_NONE; > > data->dev_flags =3D RTE_ETH_DEV_DETACHABLE; > >