From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id AB35AFB5D; Thu, 19 Jan 2017 09:24:02 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 19 Jan 2017 00:24:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,252,1477983600"; d="scan'208";a="1114875671" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 19 Jan 2017 00:24:01 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 00:24:01 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 00:24:00 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Thu, 19 Jan 2017 16:23:58 +0800 From: "Tan, Jianfeng" To: Yuanhan Liu CC: "Yigit, Ferruh" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name Thread-Index: AQHScYAXnxW03Xcmgk642i33+JZqX6E9maKAgACmPGD//51uAIABIiQQ///wGoCAAIb0AA== Date: Thu, 19 Jan 2017 08:23:58 +0000 Message-ID: References: <1484739849-72803-1-git-send-email-jianfeng.tan@intel.com> <8fea300e-350e-6b83-a706-acadec98afc8@intel.com> <20170119081625.GV9046@yliu-dev.sh.intel.com> In-Reply-To: <20170119081625.GV9046@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 08:24:03 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Thursday, January 19, 2017 4:16 PM > To: Tan, Jianfeng > Cc: Yigit, Ferruh; dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver na= me >=20 > On Thu, Jan 19, 2017 at 09:16:58AM +0800, Tan, Jianfeng wrote: > > > >> On 1/18/2017 11:44 AM, Jianfeng Tan wrote: > > > >>> API rte_eth_dev_info_get() fills driver name according to drv_nam= e > > > >>> of rte_eth_dev_data. But we have not fill such info in virtio_use= r. > > > >>> > > > >>> We do not use the same one with virtio device as some application= s > > > >>> might depend on driver name to differetiate kinds of devices, suc= h > > > >>> as VPP. > > > >>> > > > >>> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver= ") > > > >>> CC: stable@dpdk.org > > > >>> > > > >>> Signed-off-by: Jianfeng Tan > > > >>> --- > > > >>> drivers/net/virtio/virtio_user_ethdev.c | 1 + > > > >>> 1 file changed, 1 insertion(+) > > > >>> > > > >>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c > > > >> b/drivers/net/virtio/virtio_user_ethdev.c > > > >>> index c877968..110f6a9 100644 > > > >>> --- a/drivers/net/virtio/virtio_user_ethdev.c > > > >>> +++ b/drivers/net/virtio/virtio_user_ethdev.c > > > >>> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name) > > > >>> hw->use_simple_rxtx =3D 0; > > > >>> hw->virtio_user_dev =3D dev; > > > >>> data->dev_private =3D hw; > > > >>> + data->drv_name =3D "virtio_user PMD"; > > > >> > > > >> How driver naming done changed in next-net. > > > >> Please check any other virtual driver in next-net for sample. > > > > > > > > Thank you for the info. And it seems that it's already fixed by tha= t patch. > > > > > > That patch modified during merge, can you please confirm the latest > > > version in the repo? > > > > Just checked latest master repo, this problem has been fixed by commit > 73db5badb04 ("net: align ethdev and eal driver names"). Thanks to David > Marchand. > > > > Yuanhan, do you think this patch can be applied to the stable repo? >=20 > I think I would partially backport that commit to a stable release: just > pick the virtio changes, with a brand new commit log, stating the issue > need to be fixed and it's a partial backport from 73db5badb04 ("net: alig= n > ethdev and eal driver names"). >=20 > Okay to you? That will be great. Actually, I'm wondering if possible to make your work e= asier by just adding another very simple fix only to stable branch. Thanks, Jianfeng >=20 > --yliu