From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"shahafs@mellanox.com" <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support
Date: Tue, 5 Sep 2017 03:41:00 +0000 [thread overview]
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E36512AFF27@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170904144916.GE11856@bricha3-MOBL3.ger.corp.intel.com>
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Monday, September 4, 2017 10:49 PM
> To: Tan, Jianfeng
> Cc: dev@dpdk.org; xen-devel@lists.xenproject.org; thomas@monjalon.net;
> Mcnamara, John; joao.m.martins@oracle.com;
> jerin.jacob@caviumnetworks.com; shahafs@mellanox.com
> Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support
>
> On Mon, Sep 04, 2017 at 03:43:02PM +0100, Bruce Richardson wrote:
> > On Wed, Aug 30, 2017 at 06:10:33PM +0000, Jianfeng Tan wrote:
> > > We remove xen-specific code in EAL, including the option --xen-dom0,
> > > memory initialization code, compiling dependency, etc.
> > >
> > > Besides, related documents are removed or updated.
> > >
> > > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> > > ---
> > > MAINTAINERS | 7 -
> > > config/common_base | 5 -
> > > doc/guides/index.rst | 1 -
> > > doc/guides/linux_gsg/build_sample_apps.rst | 5 +-
> > > doc/guides/linux_gsg/sys_reqs.rst | 53 --
> > > doc/guides/prog_guide/source_org.rst | 1 -
> > > doc/guides/rel_notes/deprecation.rst | 3 -
> > > doc/guides/rel_notes/release_17_11.rst | 12 +
> > > doc/guides/testpmd_app_ug/run_app.rst | 4 -
> > > doc/guides/xen/img/dpdk_xen_pkt_switch.png | Bin 163842 -> 0
> bytes
> > > doc/guides/xen/img/grant_refs.png | Bin 6405 -> 0 bytes
> > > doc/guides/xen/img/grant_table.png | Bin 96762 -> 0 bytes
> > > doc/guides/xen/index.rst | 38 -
> > > doc/guides/xen/pkt_switch.rst | 470 -------------
> > > .../bsdapp/eal/include/exec-env/rte_dom0_common.h | 107 ---
> > > lib/librte_eal/common/eal_common_options.c | 3 -
> > > lib/librte_eal/common/eal_internal_cfg.h | 1 -
> > > lib/librte_eal/common/eal_options.h | 2 -
> > > lib/librte_eal/common/include/rte_memory.h | 66 --
> > > lib/librte_eal/linuxapp/Makefile | 2 -
> > > lib/librte_eal/linuxapp/eal/Makefile | 5 +-
> > > lib/librte_eal/linuxapp/eal/eal.c | 24 -
> > > lib/librte_eal/linuxapp/eal/eal_memory.c | 56 --
> > > lib/librte_eal/linuxapp/eal/eal_xen_memory.c | 381 ----------
> > > .../eal/include/exec-env/rte_dom0_common.h | 108 ---
> > > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 54 --
> > > lib/librte_eal/linuxapp/xen_dom0/Makefile | 53 --
> > > lib/librte_eal/linuxapp/xen_dom0/compat.h | 15 -
> > > lib/librte_eal/linuxapp/xen_dom0/dom0_mm_dev.h | 107 ---
> > > lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c | 780 --------------
> -------
> > > pkg/dpdk.spec | 3 -
> >
> > The xen functions that were removed are still listed in the linux/bsd
> > version.map files. Not an ABI versioning expert, but I believe they
> > should be removed as they are no longer present.
> >
> Reading the contributors guide section on ABI, specifically
> http://dpdk.org/doc/guides/contributing/versioning.html#deprecating-an-
> entire-abi-version
> it seems like we should collapse down the versions to a single one
> following the function removal, and also increment the whole library so
> version.
So for lib/librte_eal/linuxapp/eal/rte_eal_version.map, we should change it in below way?
DPDK_2.1 {
{APIs in DPDK_2.0 except xen APIs}
...
};
DPDK_16.04 {
{APIs in DPDK_2.1 except xen APIs}
...
} DPDK_2.1;
DPDK_16.07 {
...
} DPDK_16.04;
...
next prev parent reply other threads:[~2017-09-05 3:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 18:10 [dpdk-dev] [PATCH 0/6] remove xen dom0 support in DPDK Jianfeng Tan
2017-08-30 18:10 ` [dpdk-dev] [PATCH 1/6] example/vhost_xen: remove Jianfeng Tan
2017-09-04 14:14 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 2/6] net/xenvirt: remove Jianfeng Tan
2017-09-04 14:25 ` Bruce Richardson
2017-09-04 14:50 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 3/6] xen: remove xen dependency in app, examples, test Jianfeng Tan
2017-09-04 14:24 ` Bruce Richardson
2017-09-04 14:51 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 4/6] xen: remove xen dependency in drivers, ether, mempool Jianfeng Tan
2017-09-04 14:51 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support Jianfeng Tan
2017-09-04 14:43 ` Bruce Richardson
2017-09-04 14:49 ` Bruce Richardson
2017-09-05 3:41 ` Tan, Jianfeng [this message]
2017-09-05 7:31 ` Thomas Monjalon
2017-09-05 8:07 ` Tan, Jianfeng
2017-09-05 8:34 ` Thomas Monjalon
2017-08-30 18:10 ` [dpdk-dev] [PATCH 6/6] eal: remove API rte_mem_phy2mch Jianfeng Tan
2017-09-04 14:52 ` Bruce Richardson
2017-08-31 8:44 ` [dpdk-dev] [Xen-devel] [PATCH 0/6] remove xen dom0 support in DPDK Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED26CBA2FAD1BF48A8719AEF02201E36512AFF27@SHSMSX103.ccr.corp.intel.com \
--to=jianfeng.tan@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=joao.m.martins@oracle.com \
--cc=john.mcnamara@intel.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).