From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C06DD2C01 for ; Tue, 5 Sep 2017 05:41:05 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 20:41:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,477,1498546800"; d="scan'208";a="131718819" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 04 Sep 2017 20:41:04 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Sep 2017 20:41:04 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Sep 2017 20:41:03 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.219]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0319.002; Tue, 5 Sep 2017 11:41:01 +0800 From: "Tan, Jianfeng" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "xen-devel@lists.xenproject.org" , "thomas@monjalon.net" , "Mcnamara, John" , "joao.m.martins@oracle.com" , "jerin.jacob@caviumnetworks.com" , "shahafs@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support Thread-Index: AQHTIbs4e1puUiLzJESHmJF6ZBnvPqKkTqUAgAABvgCAAVv+AA== Date: Tue, 5 Sep 2017 03:41:00 +0000 Message-ID: References: <1504116634-115687-1-git-send-email-jianfeng.tan@intel.com> <1504116634-115687-6-git-send-email-jianfeng.tan@intel.com> <20170904144302.GD11856@bricha3-MOBL3.ger.corp.intel.com> <20170904144916.GE11856@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170904144916.GE11856@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 03:41:06 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Monday, September 4, 2017 10:49 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; xen-devel@lists.xenproject.org; thomas@monjalon.net; > Mcnamara, John; joao.m.martins@oracle.com; > jerin.jacob@caviumnetworks.com; shahafs@mellanox.com > Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support >=20 > On Mon, Sep 04, 2017 at 03:43:02PM +0100, Bruce Richardson wrote: > > On Wed, Aug 30, 2017 at 06:10:33PM +0000, Jianfeng Tan wrote: > > > We remove xen-specific code in EAL, including the option --xen-dom0, > > > memory initialization code, compiling dependency, etc. > > > > > > Besides, related documents are removed or updated. > > > > > > Signed-off-by: Jianfeng Tan > > > --- > > > MAINTAINERS | 7 - > > > config/common_base | 5 - > > > doc/guides/index.rst | 1 - > > > doc/guides/linux_gsg/build_sample_apps.rst | 5 +- > > > doc/guides/linux_gsg/sys_reqs.rst | 53 -- > > > doc/guides/prog_guide/source_org.rst | 1 - > > > doc/guides/rel_notes/deprecation.rst | 3 - > > > doc/guides/rel_notes/release_17_11.rst | 12 + > > > doc/guides/testpmd_app_ug/run_app.rst | 4 - > > > doc/guides/xen/img/dpdk_xen_pkt_switch.png | Bin 163842 -> 0 > bytes > > > doc/guides/xen/img/grant_refs.png | Bin 6405 -> 0 b= ytes > > > doc/guides/xen/img/grant_table.png | Bin 96762 -> 0 = bytes > > > doc/guides/xen/index.rst | 38 - > > > doc/guides/xen/pkt_switch.rst | 470 -----------= -- > > > .../bsdapp/eal/include/exec-env/rte_dom0_common.h | 107 --- > > > lib/librte_eal/common/eal_common_options.c | 3 - > > > lib/librte_eal/common/eal_internal_cfg.h | 1 - > > > lib/librte_eal/common/eal_options.h | 2 - > > > lib/librte_eal/common/include/rte_memory.h | 66 -- > > > lib/librte_eal/linuxapp/Makefile | 2 - > > > lib/librte_eal/linuxapp/eal/Makefile | 5 +- > > > lib/librte_eal/linuxapp/eal/eal.c | 24 - > > > lib/librte_eal/linuxapp/eal/eal_memory.c | 56 -- > > > lib/librte_eal/linuxapp/eal/eal_xen_memory.c | 381 ---------- > > > .../eal/include/exec-env/rte_dom0_common.h | 108 --- > > > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 54 -- > > > lib/librte_eal/linuxapp/xen_dom0/Makefile | 53 -- > > > lib/librte_eal/linuxapp/xen_dom0/compat.h | 15 - > > > lib/librte_eal/linuxapp/xen_dom0/dom0_mm_dev.h | 107 --- > > > lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c | 780 -----------= --- > ------- > > > pkg/dpdk.spec | 3 - > > > > The xen functions that were removed are still listed in the linux/bsd > > version.map files. Not an ABI versioning expert, but I believe they > > should be removed as they are no longer present. > > > Reading the contributors guide section on ABI, specifically > http://dpdk.org/doc/guides/contributing/versioning.html#deprecating-an- > entire-abi-version > it seems like we should collapse down the versions to a single one > following the function removal, and also increment the whole library so > version. So for lib/librte_eal/linuxapp/eal/rte_eal_version.map, we should change it= in below way? DPDK_2.1 { {APIs in DPDK_2.0 except xen APIs} ... }; DPDK_16.04 { {APIs in DPDK_2.1 except xen APIs} ... } DPDK_2.1; DPDK_16.07 { ... } DPDK_16.04; ...