From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1C79E330D for ; Tue, 5 Sep 2017 10:07:17 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2017 01:07:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,479,1498546800"; d="scan'208";a="125632383" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 05 Sep 2017 01:07:16 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 5 Sep 2017 01:07:16 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 5 Sep 2017 01:07:15 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.219]) by shsmsx102.ccr.corp.intel.com ([169.254.2.39]) with mapi id 14.03.0319.002; Tue, 5 Sep 2017 16:07:12 +0800 From: "Tan, Jianfeng" To: Thomas Monjalon CC: "Richardson, Bruce" , "dev@dpdk.org" , "xen-devel@lists.xenproject.org" , "Mcnamara, John" , "joao.m.martins@oracle.com" , "jerin.jacob@caviumnetworks.com" , "shahafs@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support Thread-Index: AQHTIbs4e1puUiLzJESHmJF6ZBnvPqKkTqUAgAABvgCAAVv+AP//vAUAgACK1KA= Date: Tue, 5 Sep 2017 08:07:11 +0000 Message-ID: References: <1504116634-115687-1-git-send-email-jianfeng.tan@intel.com> <20170904144916.GE11856@bricha3-MOBL3.ger.corp.intel.com> <18154944.ikgZCrDS5M@xps> In-Reply-To: <18154944.ikgZCrDS5M@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 08:07:18 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, September 5, 2017 3:31 PM > To: Tan, Jianfeng > Cc: Richardson, Bruce; dev@dpdk.org; xen-devel@lists.xenproject.org; > Mcnamara, John; joao.m.martins@oracle.com; > jerin.jacob@caviumnetworks.com; shahafs@mellanox.com > Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support >=20 > 05/09/2017 05:41, Tan, Jianfeng: > > From: Richardson, Bruce > > > > > > Reading the contributors guide section on ABI, specifically > > > http://dpdk.org/doc/guides/contributing/versioning.html#deprecating- > an- > > > entire-abi-version > > > it seems like we should collapse down the versions to a single one > > > following the function removal, and also increment the whole library = so > > > version. > > > > So for lib/librte_eal/linuxapp/eal/rte_eal_version.map, we should chang= e > it in below way? > > > > DPDK_2.1 { > > {APIs in DPDK_2.0 except xen APIs} > > ... > > }; > > > > DPDK_16.04 { > > {APIs in DPDK_2.1 except xen APIs} > > ... > > } DPDK_2.1; >=20 > No, you don't need to collapse. You can just remove Xen functions. Thanks. Besides, two more things:=20 1. Shall we increase the so version? 2. This patch is about 8K lines long, do we need to split?