From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix compile error
Date: Mon, 16 Oct 2017 10:10:25 +0000 [thread overview]
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E3651315B8E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1508119093-42500-1-git-send-email-jingjing.wu@intel.com>
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Monday, October 16, 2017 9:58 AM
> To: Tan, Jianfeng
> Cc: dev@dpdk.org; Wu, Jingjing
> Subject: [PATCH] igb_uio: fix compile error
>
> Compile fails when kernel version is <= 3.17 with error:
> "dereferencing pointer to incomplete type". This is because struct
> uio_device definition is not exposed in kernel earlier than 3.17.
>
> This patch fixes it by using pointer of rte_uio_pci_dev as
> dev_id instead of uio_device for irq device handler.
>
> Fixes: 5f6ff30dc507 ("igb_uio: fix interrupt enablement after FLR in VM")
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Yes, we don't have to use struct uio_device as the cookie; what we need is struct uio_info for notification.
Reviewed-by: Jianfeng Tan <jianfeng.tan@intel.com>
Thanks,
Jianfeng
next prev parent reply other threads:[~2017-10-16 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 1:58 Jingjing Wu
2017-10-16 10:10 ` Tan, Jianfeng [this message]
2017-10-16 10:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED26CBA2FAD1BF48A8719AEF02201E3651315B8E@SHSMSX103.ccr.corp.intel.com \
--to=jianfeng.tan@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).