From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 384AF1B5E4 for ; Mon, 16 Oct 2017 12:10:28 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP; 16 Oct 2017 03:10:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,386,1503385200"; d="scan'208";a="160949944" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 16 Oct 2017 03:10:26 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 16 Oct 2017 03:10:27 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 16 Oct 2017 03:10:26 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Mon, 16 Oct 2017 18:10:24 +0800 From: "Tan, Jianfeng" To: "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [PATCH] igb_uio: fix compile error Thread-Index: AQHTRl+C6q7MMGFISUau+jzXnGK1LKLmPm2A Date: Mon, 16 Oct 2017 10:10:25 +0000 Message-ID: References: <1508119093-42500-1-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1508119093-42500-1-git-send-email-jingjing.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 10:10:29 -0000 > -----Original Message----- > From: Wu, Jingjing > Sent: Monday, October 16, 2017 9:58 AM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Wu, Jingjing > Subject: [PATCH] igb_uio: fix compile error >=20 > Compile fails when kernel version is <=3D 3.17 with error: > "dereferencing pointer to incomplete type". This is because struct > uio_device definition is not exposed in kernel earlier than 3.17. >=20 > This patch fixes it by using pointer of rte_uio_pci_dev as > dev_id instead of uio_device for irq device handler. >=20 > Fixes: 5f6ff30dc507 ("igb_uio: fix interrupt enablement after FLR in VM") >=20 > Signed-off-by: Jingjing Wu Yes, we don't have to use struct uio_device as the cookie; what we need is = struct uio_info for notification. Reviewed-by: Jianfeng Tan Thanks, Jianfeng