From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D5F541B398 for ; Tue, 7 Nov 2017 07:21:55 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2017 22:21:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,356,1505804400"; d="scan'208";a="918376655" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 06 Nov 2017 22:21:54 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 6 Nov 2017 22:21:54 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 6 Nov 2017 22:21:54 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Tue, 7 Nov 2017 14:21:52 +0800 From: "Tan, Jianfeng" To: Thomas Monjalon CC: "dev@dpdk.org" , "jblunck@infradead.org" , "Richardson, Bruce" , "Ananyev, Konstantin" , "De Lara Guarch, Pablo" , "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "mtetsuyah@gmail.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v11 3/4] bus/vdev: move to vdev bus to drivers/bus Thread-Index: AQHTUVjuv1pUG0w+3Uegkbj8/6BB/6MHu4kAgACn22A= Date: Tue, 7 Nov 2017 06:21:51 +0000 Message-ID: References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1509352136-49972-1-git-send-email-jianfeng.tan@intel.com> <1509352136-49972-4-git-send-email-jianfeng.tan@intel.com> <35142719.60LRBhkl3K@xps> In-Reply-To: <35142719.60LRBhkl3K@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v11 3/4] bus/vdev: move to vdev bus to drivers/bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 06:21:56 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, November 7, 2017 10:43 AM > To: Tan, Jianfeng > Cc: dev@dpdk.org; jblunck@infradead.org; Richardson, Bruce; Ananyev, > Konstantin; De Lara Guarch, Pablo; yliu@fridaylinux.org; > maxime.coquelin@redhat.com; mtetsuyah@gmail.com; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v11 3/4] bus/vdev: move to vdev bus to > drivers/bus >=20 > Hi Jianfeng, >=20 > This patch needs a rebase and some changes as described below. > Would you have time to fix it quickly please? Thank you for review. Will send out soon. =20 >=20 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -814,3 +814,8 @@ CONFIG_RTE_APP_CRYPTO_PERF=3Dy > > # Compile the eventdev application > > # > > CONFIG_RTE_APP_EVENTDEV=3Dy > > + > > +# > > +# Compile the vdev bus > > +# > > +CONFIG_RTE_LIBRTE_VDEV_BUS=3Dy >=20 > Please move this option in a more logical position. How about moving it after LIBRTE_PCI_BUS? >=20 >=20 > > --- a/lib/librte_eal/linuxapp/eal/Makefile > > +++ b/lib/librte_eal/linuxapp/eal/Makefile > > -LIBABIVER :=3D 6 > > +LIBABIVER :=3D 7 >=20 > No need to bump again the EAL version in 17.11. >=20 >=20 > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -101,6 +101,7 @@ _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) > +=3D -lrte_mempool_ring > > _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) +=3D -lrte_ring > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI) +=3D -lrte_pci > > _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) +=3D -lrte_eal > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_VDEV_BUS) +=3D -lrte_bus_vdev >=20 > I suggest to move by one line just before -lrte_eal. How about moving it to after rte_bus_pci? Thanks, Jianfeng