From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1AB111B012 for ; Wed, 3 Jan 2018 02:07:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2018 17:07:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,499,1508828400"; d="scan'208";a="191766986" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 02 Jan 2018 17:07:40 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 2 Jan 2018 17:07:40 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 2 Jan 2018 17:07:39 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Wed, 3 Jan 2018 09:07:37 +0800 From: "Tan, Jianfeng" To: "Richardson, Bruce" , "Hu, Jiayu" CC: "dev@dpdk.org" , "Chen, Junjie J" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "Yigit, Ferruh" , "Yao, Lei A" Thread-Topic: [dpdk-dev] [PATCH v3 1/2] gro: code cleanup Thread-Index: AQHTevWIghiDdGA3LECm/98ZFUWzRqNf/OiAgAFqmlA= Date: Wed, 3 Jan 2018 01:07:37 +0000 Message-ID: References: <1513219779-100115-1-git-send-email-jiayu.hu@intel.com> <1513927544-97241-1-git-send-email-jiayu.hu@intel.com> <1513927544-97241-2-git-send-email-jiayu.hu@intel.com> <20180102112600.GA10276@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20180102112600.GA10276@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] gro: code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 01:07:42 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, January 2, 2018 7:26 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Tan, Jianfeng; Chen, Junjie J; Ananyev, Konstantin; > stephen@networkplumber.org; Yigit, Ferruh; Yao, Lei A > Subject: Re: [dpdk-dev] [PATCH v3 1/2] gro: code cleanup >=20 > On Fri, Dec 22, 2017 at 03:25:43PM +0800, Jiayu Hu wrote: > > - Remove needless check and variants > > - For better understanding, update the programmer guide and rename > > internal functions and variants > > - For supporting tunneled gro, move common internal functions from > > gro_tcp4.c to gro_tcp4.h > > - Comply RFC 6864 to process the IPv4 ID field > > > > Signed-off-by: Jiayu Hu > > --- > > .../prog_guide/generic_receive_offload_lib.rst | 246 ++++++++-----= -- > > doc/guides/prog_guide/img/gro-key-algorithm.png | Bin 0 -> 28231 > bytes >=20 > Rather than binary PNG images, please use SVG files (note, real SVG, not > an SVG file with a binary blob pasted into it). Based on my limited experience, there is no shortcut for this, but re-draw = the picture with tools like visio. Thanks, Jianfeng >=20 > Thanks, > /Bruce