From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix mmap failure as len not aligned with hugepage size
Date: Thu, 12 Nov 2015 12:51:43 +0000 [thread overview]
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E3663F288@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <18810031.JvBkFVb3yD@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, November 12, 2015 7:19 PM
> To: Tan, Jianfeng
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix mmap failure as len not aligned
> with hugepage size
>
> 2015-11-12 06:04, Jianfeng Tan:
> > - alignment = region[idx].blksz;
> > - munmap((void *)(uintptr_t)
> > - RTE_ALIGN_FLOOR(
> > - region[idx].mapped_address,
> alignment),
> > - RTE_ALIGN_CEIL(
> > - region[idx].mapped_size,
> alignment));
> > + munmap((void *)region[idx].mapped_address,
> > + region[idx].mapped_size);
>
> Sorry, it does not compile for 32-bit:
> virtio-net-user.c:84:11: error: cast to pointer from integer of different size
Oops, sorry, should use (void *)(uintptr_t). I'll resend this patch.
Jianfeng
prev parent reply other threads:[~2015-11-12 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 22:04 Jianfeng Tan
2015-11-12 6:06 ` [dpdk-dev] [PATCH v3] " Jianfeng Tan
2015-11-24 18:24 ` Thomas Monjalon
2015-11-12 6:39 ` [dpdk-dev] [PATCH v2] " Xie, Huawei
2015-11-12 11:18 ` Thomas Monjalon
2015-11-12 12:51 ` Tan, Jianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED26CBA2FAD1BF48A8719AEF02201E3663F288@SHSMSX152.ccr.corp.intel.com \
--to=jianfeng.tan@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).