From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1C2442A5B for ; Thu, 3 Dec 2015 07:24:28 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 02 Dec 2015 22:24:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,376,1444719600"; d="scan'208";a="6660958" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 02 Dec 2015 22:24:28 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Dec 2015 22:24:27 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Dec 2015 22:24:27 -0800 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.193]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.92]) with mapi id 14.03.0248.002; Thu, 3 Dec 2015 14:24:24 +0800 From: "Tan, Jianfeng" To: Yuanhan Liu Thread-Topic: [dpdk-dev] [PATCH v2] examples/vhost: fix statistics error Thread-Index: AQHRLYfFUhWrj7Cj0EWUpKVO2w1He564Q3CAgACHi0A= Date: Thu, 3 Dec 2015 06:24:24 +0000 Message-ID: References: <1449009174-93334-1-git-send-email-jianfeng.tan@intel.com> <1449093693-112570-1-git-send-email-jianfeng.tan@intel.com> <20151203061737.GY2325@yliu-dev.sh.intel.com> In-Reply-To: <20151203061737.GY2325@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: fix statistics error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 06:24:29 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Thursday, December 3, 2015 2:18 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: fix statistics error >=20 > On Thu, Dec 03, 2015 at 06:01:33AM +0800, Jianfeng Tan wrote: > > This issue was discovered under the case of software vm2vm > > fowarding. When pkts are received from virtio device 0 and > > tx_route to virtio device 1, tx of device 0 is not updated. > > > > To fix this problem, we check each rx/tx branch to update > > stats. Besides, the stats are printed at a separated thread, > > so we design a mechanism to make sure unreasonable data will > > not show. >=20 > Fixing statistics for vm2vm case and designing a mechanism > to make sure unreasonable data will not sure are two different > things: they should be done in two different patches, but not > one. >=20 > So, again, please do not mix two (or more) things in one patch. Exactly, I found this problem when I just send out v2. Sorry for the spam. Pls review v3. Thanks, Jianfeng >=20 > --yliu