From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1E0CB1066; Wed, 25 Apr 2018 03:51:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 18:51:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,325,1520924400"; d="scan'208";a="53393281" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 24 Apr 2018 18:51:12 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Apr 2018 18:51:11 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.79]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.6]) with mapi id 14.03.0319.002; Wed, 25 Apr 2018 09:51:09 +0800 From: "Hu, Jiayu" To: Ophir Munk , "Ananyev, Konstantin" , "dev@dpdk.org" CC: Thomas Monjalon , Olga Shern , Pascal Mazon , "stable@dpdk.org" Thread-Topic: [PATCH v1] gso: fix marking TCP checksum flag in TCP segments Thread-Index: AQHT2kUwrRaOfU8u0kiaQvDey+ryN6QNovUwgAGEBQCAABQTgIAADdEAgAAMz4CAAInx4P//jPIAgAE92BA= Date: Wed, 25 Apr 2018 01:51:08 +0000 Message-ID: References: <1524406859-29585-1-git-send-email-ophirmu@mellanox.com> <2601191342CEEE43887BDE71AB977258AEA5081C@IRSMSX102.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258AEA5221E@IRSMSX102.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjM5ZjViYTgtZDA5ZS00N2YzLWIwNmEtODFjMDliNWNjZTdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJmcnVxV3ljZWZSYUFOeW1OMEpEWDljRTlBMlwvbzlZczZYV3lwN2NXVlRNPSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 01:51:14 -0000 Hi Ophir, > -----Original Message----- > From: Ophir Munk [mailto:ophirmu@mellanox.com] > Sent: Tuesday, April 24, 2018 9:53 PM > To: Hu, Jiayu ; Ananyev, Konstantin > ; dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > ; Pascal Mazon ; > stable@dpdk.org > Subject: RE: [PATCH v1] gso: fix marking TCP checksum flag in TCP > segments >=20 > Hi Jiayu, >=20 > > -----Original Message----- > > From: Hu, Jiayu [mailto:jiayu.hu@intel.com] > > Sent: Tuesday, April 24, 2018 3:56 PM > > To: Ananyev, Konstantin ; Ophir Munk > > ; dev@dpdk.org > > Cc: Thomas Monjalon ; Olga Shern > > ; Pascal Mazon ; > > stable@dpdk.org > > Subject: RE: [PATCH v1] gso: fix marking TCP checksum flag in TCP > segments > > > > Hi Konstantin and Ophir, > > > ... > > > Another possibility - might be make chages in librte_gso to allow use= r > > > to specify what flags to set for the output packets (probably via > > > rte_gso_ctx.flag) > > > > It would be a solution. We can add flags to rte_gso_ctx.flag and the GS= O > > library can do some extra work (like checksum) according to the flags. > > >=20 > I think that calculating TCP checksums by GSO library should be optional = (if > at all). > In my case I prefer TAP PMD to do the work which is TAP-specific. > My original intention in this patch was only to mark PKT_TX_TCP_CKSUM > flag. One possible workaround is: We can have many flags. Some flags are for real checksum calculation, but some flags can be used to tell the GSO library to prepare HW TCP checksum offloading. When preparing HW TCP checksum offloading, the GSO library can only set TCP_CKSUM flag. Since some the HW drivers have supported rte_eth_tx_prepare(), which will calculate the pseudo IP header checksum, applications can call rte_eth_tx_prepare() to do real checksum offloading preparation after calli= ng the GSO library. Thanks, Jiayu >=20 > > Thanks, > > Jiayu > > > > > > Konstantin > > > > ...