From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 08C5C1B8C3 for ; Sat, 16 Jun 2018 11:14:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jun 2018 02:14:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,230,1526367600"; d="scan'208";a="49801548" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga008.jf.intel.com with ESMTP; 16 Jun 2018 02:14:57 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 16 Jun 2018 02:14:57 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 16 Jun 2018 02:14:57 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.70]) with mapi id 14.03.0319.002; Sat, 16 Jun 2018 17:14:55 +0800 From: "Hu, Jiayu" To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the checksum forwarding engine Thread-Index: AQHUA+4rbxfG3lHWjUGDP9IRBQvJnqRimtpw Date: Sat, 16 Jun 2018 09:14:54 +0000 Message-ID: References: <1527579670-91026-1-git-send-email-jiayu.hu@intel.com> <1527579670-91026-3-git-send-email-jiayu.hu@intel.com> <8CEF83825BEC744B83065625E567D7C260CB37DB@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB37DB@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzdjMTNhMWQtY2M4YS00MjdjLWFmNjctMDkyNGEzOGY4NjI3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFwvWjhqNWFKSG1pVU5pSWt4XC9Ncm5YbElPR1d2WCtaNlBtWEorSkRZMHRWaGVNeGJcL0pTNFNqMUFHT2pjTUhWbCJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the checksum forwarding engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2018 09:15:01 -0000 Hi Bernard, > -----Original Message----- > From: Iremonger, Bernard > Sent: Thursday, June 14, 2018 10:44 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Hu, Jiayu > > Subject: RE: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the > checksum forwarding engine >=20 > Hi Jiayu, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiayu Hu > > Sent: Tuesday, May 29, 2018 8:41 AM > > To: dev@dpdk.org > > Cc: Ananyev, Konstantin ; Hu, Jiayu > > > > Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the > > checksum forwarding engine > > > > This patch enables GSO for UDP/IPv4 packets. Oversized UDP/IPv4 > packets > > transmitted over a GSO-enabled port will undergo segmentation. > > > > Signed-off-by: Jiayu Hu > > --- > > app/test-pmd/cmdline.c | 5 +++-- > > app/test-pmd/csumonly.c | 2 ++ > > app/test-pmd/testpmd.c | 2 +- > > 3 files changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 27e2aa8..4239e91 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -4792,8 +4792,9 @@ cmd_gso_show_parsed(void *parsed_result, > > if (gso_ports[res->cmd_pid].enable) { > > printf("Max GSO'd packet size: %uB\n" > > "Supported GSO types: TCP/IPv4, " > > - "VxLAN with inner TCP/IPv4 packet, > " > > - "GRE with inner TCP/IPv4 > packet\n", > > + "UDP/IPv4, VxLAN with inner " > > + "TCP/IPv4 packet, GRE with inner " > > + "TCP/IPv4 packet\n", >=20 > This change is giving 3 checkpatch.pl warnings and should be refactored The file test-pmd/cmdline.c uses the above coding style to split long strin= gs, so I think I need to keep this style. But when I use it, there are always s= ome warnings. >=20 >=20 > > gso_max_segment_size); > > } else > > printf("GSO is not enabled on Port %u\n", res- > > >cmd_pid); diff --git a/app/test-pmd/csumonly.c b/app/test- > > pmd/csumonly.c index 0bb88cf..4948292 100644 > > --- a/app/test-pmd/csumonly.c > > +++ b/app/test-pmd/csumonly.c > > @@ -411,6 +411,8 @@ process_inner_cksums(void *l3_hdr, const struct > > testpmd_offload_info *info, > > info->ethertype); > > } > > } > > + if (info->gso_enable) > > + ol_flags |=3D PKT_TX_UDP_SEG; > > } else if (info->l4_proto =3D=3D IPPROTO_TCP) { > > tcp_hdr =3D (struct tcp_hdr *)((char *)l3_hdr + info->l3_len); > > tcp_hdr->cksum =3D 0; > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > 35cf266..b5766ff 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -777,7 +777,7 @@ init_config(void) > > init_port_config(); > > > > gso_types =3D DEV_TX_OFFLOAD_TCP_TSO | > > DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > > - DEV_TX_OFFLOAD_GRE_TNL_TSO; > > + DEV_TX_OFFLOAD_GRE_TNL_TSO | > > DEV_TX_OFFLOAD_UDP_TSO; > > /* > > * Records which Mbuf pool to use by each logical core, if needed. > > */ > > -- > > 2.7.4 >=20 > ./devtools/check-git-log.sh -1 > Headline too long: > app/testpmd: enable UDP GSO in the checksum forwarding engine Will change it in the next version. >=20 > Should the dpdk/doc/guides/testpmd_ap_ug/testpmd_funcs.rst file be > updated? I will add some descriptions about UDP/IPv4 GSO usage guide in it. Thanks, Jiayu >=20 > Regards, >=20 > Bernard >=20