From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 18E811BB37 for ; Thu, 21 Jun 2018 10:26:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 01:26:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,251,1526367600"; d="scan'208";a="48761046" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga007.fm.intel.com with ESMTP; 21 Jun 2018 01:26:49 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 01:26:49 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.70]) with mapi id 14.03.0319.002; Thu, 21 Jun 2018 16:26:47 +0800 From: "Hu, Jiayu" To: "Wang, Xiao W" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Zhang, Yuwei1" , "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH v2 1/3] gso: support UDP/IPv4 fragmentation Thread-Index: AQHUBegagQ1i9oh9fEWwqckGwkw74KRp4K2AgACGSoA= Date: Thu, 21 Jun 2018 08:26:47 +0000 Message-ID: References: <1527579670-91026-1-git-send-email-jiayu.hu@intel.com> <1529205194-87434-1-git-send-email-jiayu.hu@intel.com> <1529205194-87434-2-git-send-email-jiayu.hu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjg4MjhhNGQtYTMyMS00NmMzLWE4OGMtOWI0ZDExY2RiN2Q3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTXh1MjVrTTlIOWUrb1NOdXdFTVFMQUswSVdPcllsUmJTVkR3dnVoR3N5Z2I1SjdkWEh4R1dWNE5JYVNjU296VSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] gso: support UDP/IPv4 fragmentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 08:26:51 -0000 Hi Xiao, > -----Original Message----- > From: Wang, Xiao W > Sent: Thursday, June 21, 2018 4:25 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Zhang, Yuwei1 > ; Iremonger, Bernard > ; Hu, Jiayu > Subject: RE: [dpdk-dev] [PATCH v2 1/3] gso: support UDP/IPv4 > fragmentation >=20 > Hi, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiayu Hu > > Sent: Sunday, June 17, 2018 11:13 AM > > To: dev@dpdk.org > > Cc: Ananyev, Konstantin ; Zhang, Yuwei1 > > ; Iremonger, Bernard > > ; Hu, Jiayu > > Subject: [dpdk-dev] [PATCH v2 1/3] gso: support UDP/IPv4 fragmentation > > > > This patch adds GSO support for UDP/IPv4 packets. Supported packets > > may include a single VLAN tag. UDP/IPv4 GSO doesn't check if input > > packets have correct checksums, and doesn't update checksums for > > output packets (the responsibility for this lies with the application). > > Additionally, UDP/IPv4 GSO doesn't process IP fragmented packets. > > > > UDP/IPv4 GSO uses two chained MBUFs, one direct MBUF and one indrect > > MBUF, to organize an output packet. The direct MBUF stores the packet > > header, while the indirect mbuf simply points to a location within the > > original packet's payload. Consequently, use of UDP GSO requires > > multi-segment MBUF support in the TX functions of the NIC driver. > > > > If a packet is GSO'd, UDP/IPv4 GSO reduces its MBUF refcnt by 1. As a > > result, when all of its GSOed segments are freed, the packet is freed > > automatically. > > > > Signed-off-by: Jiayu Hu > > --- > > lib/librte_gso/Makefile | 1 + > > lib/librte_gso/gso_common.h | 3 ++ > > lib/librte_gso/gso_udp4.c | 81 > > +++++++++++++++++++++++++++++++++++++++++++++ > > lib/librte_gso/gso_udp4.h | 42 +++++++++++++++++++++++ > > lib/librte_gso/rte_gso.c | 24 +++++++++++--- > > lib/librte_gso/rte_gso.h | 6 +++- > > 6 files changed, 151 insertions(+), 6 deletions(-) > > create mode 100644 lib/librte_gso/gso_udp4.c > > create mode 100644 lib/librte_gso/gso_udp4.h > > > > diff --git a/lib/librte_gso/Makefile b/lib/librte_gso/Makefile > > index 3648ec0..1fac53a 100644 > > --- a/lib/librte_gso/Makefile > > +++ b/lib/librte_gso/Makefile > > @@ -19,6 +19,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_GSO) +=3D rte_gso.c > > SRCS-$(CONFIG_RTE_LIBRTE_GSO) +=3D gso_common.c > > SRCS-$(CONFIG_RTE_LIBRTE_GSO) +=3D gso_tcp4.c > > SRCS-$(CONFIG_RTE_LIBRTE_GSO) +=3D gso_tunnel_tcp4.c > > +SRCS-$(CONFIG_RTE_LIBRTE_GSO) +=3D gso_udp4.c > > >=20 > meson should be updated accordingly. Thanks a lot. Update later. >=20 > > # install this header file > > SYMLINK-$(CONFIG_RTE_LIBRTE_GSO)-include +=3D rte_gso.h > > diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h > > index 5ca5974..6cd764f 100644 > > --- a/lib/librte_gso/gso_common.h > > +++ b/lib/librte_gso/gso_common.h > > @@ -31,6 +31,9 @@ > > (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | > \ > > PKT_TX_TUNNEL_GRE)) > > > > +#define IS_IPV4_UDP(flag) (((flag) & (PKT_TX_UDP_SEG | PKT_TX_IPV4)) > =3D=3D \ > > + (PKT_TX_UDP_SEG | PKT_TX_IPV4)) > > + > > /** > > * Internal function which updates the UDP header of a packet, followi= ng > > * segmentation. This is required to update the header's datagram leng= th > field. > > diff --git a/lib/librte_gso/gso_udp4.c b/lib/librte_gso/gso_udp4.c > > new file mode 100644 > > index 0000000..a3db329 > > --- /dev/null > > +++ b/lib/librte_gso/gso_udp4.c > > @@ -0,0 +1,81 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2018 Intel Corporation > > + */ > > + > > +#include "gso_common.h" > > +#include "gso_udp4.h" > > + > > +#define IPV4_HDR_MF_BIT (1U << 13) > > + > > +static inline void > > +update_ipv4_udp_headers(struct rte_mbuf *pkt, struct rte_mbuf **segs, > > + uint16_t nb_segs) > > +{ > > + struct ipv4_hdr *ipv4_hdr; > > + uint16_t frag_offset =3D 0, is_mf; > > + uint16_t l2_hdrlen =3D pkt->l2_len, l3_hdrlen =3D pkt->l3_len; > > + uint16_t tail_idx =3D nb_segs - 1, length, i; > > + > > + /* > > + * Update IP header fields for output segments. Specifically, > > + * keep the same IP id, update fragment offset and total > > + * length. > > + */ > > + for (i =3D 0; i < nb_segs; i++) { > > + ipv4_hdr =3D (struct ipv4_hdr *)(rte_pktmbuf_mtod(segs[i], > > + char *) + l2_hdrlen); >=20 > You could use rte_pktmbuf_mtod_offset to simplify the code. Yes, you are right. Update later. >=20 > > + length =3D segs[i]->pkt_len - l2_hdrlen; > > + ipv4_hdr->total_length =3D rte_cpu_to_be_16(length); > > + > > + is_mf =3D i < tail_idx ? IPV4_HDR_MF_BIT : 0; > > + ipv4_hdr->fragment_offset =3D > > + rte_cpu_to_be_16(frag_offset | is_mf); > > + frag_offset +=3D ((length - l3_hdrlen) >> 3); > > + } > > +} > > + > > +int > > +gso_udp4_segment(struct rte_mbuf *pkt, > > + uint16_t gso_size, > > + struct rte_mempool *direct_pool, > > + struct rte_mempool *indirect_pool, > > + struct rte_mbuf **pkts_out, > > + uint16_t nb_pkts_out) > > +{ > > + struct ipv4_hdr *ipv4_hdr; > > + uint16_t pyld_unit_size, hdr_offset; > > + uint16_t frag_off; > > + int ret; > > + > > + /* Don't process the fragmented packet */ > > + ipv4_hdr =3D (struct ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) + > > + pkt->l2_len); >=20 > Ditto. >=20 > BRs, > Xiao Thanks, Jiayu