From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2C7581B216; Tue, 8 Jan 2019 14:40:11 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2019 05:40:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,454,1539673200"; d="scan'208";a="108229287" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 08 Jan 2019 05:40:10 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 8 Jan 2019 05:40:10 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 8 Jan 2019 05:40:09 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.63]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.160]) with mapi id 14.03.0415.000; Tue, 8 Jan 2019 21:40:08 +0800 From: "Hu, Jiayu" To: =?utf-8?B?TW9ydGVuIEJyw7hydXA=?= , "Ananyev, Konstantin" , Stephen Hemminger CC: "dev@dpdk.org" , "Bie, Tiwei" , "Richardson, Bruce" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] gro: add missing invalid packet checks Thread-Index: AQHUpxisSjPMmSc3QkGnTdYquJqwNaWkY1+AgACVKMD//6/tAIAAD0CAgACkjvA= Date: Tue, 8 Jan 2019 13:40:07 +0000 Message-ID: References: <1546567036-29444-1-git-send-email-jiayu.hu@intel.com> <1546927725-68831-1-git-send-email-jiayu.hu@intel.com> <20190107223151.18b185b7@hermes.lan> <2601191342CEEE43887BDE71AB977258010D900817@irsmsx105.ger.corp.intel.com> <98CBD80474FA8B44BF855DF32C47DC35B425AD@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B425AD@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmY5OWEzODktZWRlNy00ZTJiLWJiZTYtYjliZDNlMGM1YWZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZHBwQWlYeXp4WDgyR3h5cjRBRTY2QVVXQjF0d01rRFZJQ1p3K3loY1pyVE5lcnlUZDRCS3pYTXhzSlkrUFQ0QyJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2019 13:40:13 -0000 DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTW9ydGVuIEJyw7hydXAg W21haWx0bzptYkBzbWFydHNoYXJlc3lzdGVtcy5jb21dDQo+IFNlbnQ6IFR1ZXNkYXksIEphbnVh cnkgOCwgMjAxOSA3OjM0IFBNDQo+IFRvOiBBbmFueWV2LCBLb25zdGFudGluIDxrb25zdGFudGlu LmFuYW55ZXZAaW50ZWwuY29tPjsgSHUsIEppYXl1DQo+IDxqaWF5dS5odUBpbnRlbC5jb20+OyBT dGVwaGVuIEhlbW1pbmdlcg0KPiA8c3RlcGhlbkBuZXR3b3JrcGx1bWJlci5vcmc+DQo+IENjOiBk ZXZAZHBkay5vcmc7IEJpZSwgVGl3ZWkgPHRpd2VpLmJpZUBpbnRlbC5jb20+OyBSaWNoYXJkc29u LCBCcnVjZQ0KPiA8YnJ1Y2UucmljaGFyZHNvbkBpbnRlbC5jb20+OyBzdGFibGVAZHBkay5vcmcN Cj4gU3ViamVjdDogUkU6IFtkcGRrLWRldl0gW1BBVENIXSBncm86IGFkZCBtaXNzaW5nIGludmFs aWQgcGFja2V0IGNoZWNrcw0KPiANCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ IEZyb206IGRldiBbbWFpbHRvOmRldi1ib3VuY2VzQGRwZGsub3JnXSBPbiBCZWhhbGYgT2YgQW5h bnlldiwNCj4gPiBLb25zdGFudGluDQo+ID4gU2VudDogVHVlc2RheSwgSmFudWFyeSA4LCAyMDE5 IDExOjM5IEFNDQo+ID4gVG86IEh1LCBKaWF5dTsgU3RlcGhlbiBIZW1taW5nZXINCj4gPiBDYzog ZGV2QGRwZGsub3JnOyBCaWUsIFRpd2VpOyBSaWNoYXJkc29uLCBCcnVjZTsgc3RhYmxlQGRwZGsu b3JnDQo+ID4gU3ViamVjdDogUmU6IFtkcGRrLWRldl0gW1BBVENIXSBncm86IGFkZCBtaXNzaW5n IGludmFsaWQgcGFja2V0IGNoZWNrcw0KPiA+DQo+ID4NCj4gPg0KPiA+ID4NCj4gPiA+DQo+ID4g PiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+IEZyb206IFN0ZXBoZW4gSGVt bWluZ2VyIFttYWlsdG86c3RlcGhlbkBuZXR3b3JrcGx1bWJlci5vcmddDQo+ID4gPiA+IFNlbnQ6 IFR1ZXNkYXksIEphbnVhcnkgOCwgMjAxOSAyOjMyIFBNDQo+ID4gPiA+IFRvOiBIdSwgSmlheXUg PGppYXl1Lmh1QGludGVsLmNvbT4NCj4gPiA+ID4gQ2M6IGRldkBkcGRrLm9yZzsgQmllLCBUaXdl aSA8dGl3ZWkuYmllQGludGVsLmNvbT47IFJpY2hhcmRzb24sDQo+ID4gQnJ1Y2UNCj4gPiA+ID4g PGJydWNlLnJpY2hhcmRzb25AaW50ZWwuY29tPjsgc3RhYmxlQGRwZGsub3JnDQo+ID4gPiA+IFN1 YmplY3Q6IFJlOiBbZHBkay1kZXZdIFtQQVRDSF0gZ3JvOiBhZGQgbWlzc2luZyBpbnZhbGlkIHBh Y2tldA0KPiA+IGNoZWNrcw0KPiA+ID4gPg0KPiA+ID4gPiBPbiBUdWUsICA4IEphbiAyMDE5IDE0 OjA4OjQ1ICswODAwDQo+ID4gPiA+IEppYXl1IEh1IDxqaWF5dS5odUBpbnRlbC5jb20+IHdyb3Rl Og0KPiA+ID4gPg0KPiA+ID4gPiA+ICsJLyoNCj4gPiA+ID4gPiArCSAqIERvbid0IHByb2Nlc3Mg dGhlIHBhY2tldCB3aG9zZSBFdGhlcm5ldCwgSVB2NCBhbmQgVENQDQo+ID4gaGVhZGVyDQo+ID4g PiA+ID4gKwkgKiBsZW5ndGhzIGFyZSBpbnZhbGlkLiBJbiBhZGRpdGlvbiwgaWYgdGhlIElQdjQg aGVhZGVyDQo+ID4gY29udGFpbnMNCj4gPiA+ID4gPiArCSAqIE9wdGlvbnMsIHRoZSBwYWNrZXQg c2hvdWxkbid0IGJlIHByb2Nlc3NlZC4NCj4gPiA+ID4gPiArCSAqLw0KPiA+ID4gPiA+ICsJaWYg KHVubGlrZWx5KElMTEVHQUxfRVRIRVJfSERSTEVOKHBrdC0+bDJfbGVuKSB8fA0KPiA+ID4gPiA+ ICsJCQlJTExFR0FMX0lQVjRfSERSTEVOKHBrdC0+bDNfbGVuKSB8fA0KPiA+ID4gPiA+ICsJCQlJ TExFR0FMX1RDUF9IRFJMRU4ocGt0LT5sNF9sZW4pKSkNCj4gPiA+ID4gPiArCQlyZXR1cm4gLTE7 DQo+ID4gPg0KPiA+ID4gSW4gdGhlIEdSTyBkZXNpZ24sIHdlIGFzc3VtZSBhcHBsaWNhdGlvbnMg Z2l2ZSBjb3JyZWN0DQo+ID4gPiBNQlVGLT5sMl9sZW4vLi4gZm9yIGlucHV0IHBhY2tldHMgb2Yg R1JPLiBTcGVjaWZpY2FsbHksIEdSTw0KPiA+ID4gbGlicmFyeSBhc3N1bWVzIGFwcGxpY2F0aW9u cyB3aWxsIHNldCB2YWx1ZXMgdG8gTUJVRi0+bDJfbGVuLy4uLg0KPiA+ID4gYW5kIGd1YXJhbnRl ZSB0aGUgdmFsdWVzIGFyZSB0aGUgc2FtZSBhcyB0aGUgdmFsdWVzIGluIHRoZSBwYWNrZXQNCj4g PiA+IGhlYWRlcnMuIFRoZSByZWFzb24gZm9yIHRoaXMgYXNzdW1wdGlvbiBpcyB0byBwcm9jZXNz IGhlYWRlciBmYXN0ZXIuDQo+IA0KPiA+ID4gVGhpcyBpcyBhbHNvIHdoeSBJIHdhbnQgdG8gYWRk IHRoaXMgYXNzdW1wdGlvbiBpbiB0aGUgcHJvZ3JhbW1lcg0KPiA+ID4gZ3VpZGUuDQo+IA0KPiAr MSB0byBtb3JlIGRldGFpbGVkIGRvY3VtZW50YXRpb24gYWJvdXQgYXNzdW1wdGlvbnMgYW5kIHBy ZWNvbmRpdGlvbnMuDQo+IA0KPiANCj4gPiA+DQo+ID4gPiBUaGUgYWJvdmUgY29kZSBpcyB0byBm b3JiaWQgR1JPIHRvIHByb2Nlc3MgaW52YWxpZCBwYWNrZXRzLCB3aGljaA0KPiA+ID4gaGF2ZSBp bnZhbGlkIHBhY2tldCBoZWFkZXIgbGVuZ3RocywgbGlrZSBUQ1AgaGVhZGVyIGxlbmd0aCBpcyBs ZXNzDQo+ID4gdGhhbg0KPiA+ID4gMjAgYnl0ZXMuDQo+ID4gPg0KPiA+ID4gPg0KPiA+ID4gPiBJ IGxpa2UgaXQgd2hlbiBjb2RlIGlzIGFzIHBpY2t5IGFzIHBvc3NpYmxlIHdoZW4gZG9pbmcNCj4g PiBvcHRpbWl6YXRpb25zIGJlY2F1c2UNCj4gPiA+ID4gaXQgcmVkdWNlcyBwb3NzaWJsZSBzZWN1 cml0eSByaXNrZy4NCj4gPiA+ID4NCj4gPiA+ID4gVG8gbWUgdGhpcyBsb29rcyBtb3JlIGNvbmZ1 c2luZyBhbmQgbm90IGFzIGNhcmVmdWwgYXMgZG9pbmcgaXQNCj4gPiBsaWtlOg0KPiA+ID4gPg0K PiA+ID4gPiAJaWYgKHVubGlrZWx5KHBrdC0+bDJfbGVuICE9IEVUSEVSX0hEUl9MRU4pKQ0KPiA+ ID4gPiAJCXJldHVybiAtMTsNCj4gPiA+ID4gCWV0aF9oZHIgPSBydGVfcGt0bWJ1Zl9tdG9kKHBr dCwgc3RydWN0IGV0aGVyX2hkciAqKTsNCj4gPiA+ID4gCWlwdjRfaGRyID0gKHN0cnVjdCBpcHY0 X2hkciAqKSgoY2hhciAqKWV0aF9oZHIgKyBFVEhFUl9IRFJfTEVOKTsNCj4gPiA+ID4NCj4gPiA+ ID4gCWlmIChwa3QtPmwzX2xlbiAhPSAoaXB2NC0+dmVyc2lvbl9paGwgJiBJUFY0X0hEUl9JSExf TUFTSykgPDwgNCkNCj4gPiA+ID4gCQlyZXR1cm4gLTE7DQo+ID4gPiA+DQo+ID4gPiA+IAlpZiAo cGt0LT5sNF9sZW4gPCBzaXplb2Yoc3RydWN0IHRjcF9oZHIpKQ0KPiA+ID4gPiAJCXJldHVybiAt MTsNCj4gPiA+ID4NCj4gPiA+ID4gWW91IHNob3VsZCBhbHNvIGNoZWNrIGZvciBUQ1Agb3B0aW9u cyBhcyB3ZWxsLg0KPiA+ID4NCj4gPiA+IFRoZXJlIGFyZSB0d28gd2F5cyB0byBnZXQgZXRoZXIs IGlwdjQgYW5kIHRjcCBoZWFkZXJzOg0KPiA+ID4gMSkuIFVzZSBNQlVGLT5sMl9sZW4vbDNfbGVu Li4uOw0KPiA+ID4gMikuIFBhcnNlIHBhY2tldCBhbmQgaWdub3JlIE1CVUYtPmwyX2xlbi8uLi4u DQo+ID4gPg0KPiA+ID4gSWYgd2UgZm9sbG93IHRoZSBjaG9pY2UgMSwgd2UgZG9uJ3QgbmVlZCB0 byBwYXJzZSBwYWNrZXQgYW5kDQo+ID4gPiBkb24ndCBuZWVkIHRvIGNoZWNrIGlmIHZhbHVlcyBv ZiBNQlVGLT5sMl9sZW4vLi4uIGFyZSBjb3JyZWN0LA0KPiA+ID4gc2luY2Ugd2UgYXNzdW1lIGFw cGxpY2F0aW9ucyB3aWxsIHNldCBjb3JyZWN0IHZhbHVlcy4gSWYgd2UgZm9sbG93DQo+ID4gPiB0 aGUgY2hvaWNlIDIsIHdlIGRvbid0IG5lZWQgdG8gY2FyZSBhYm91dCB0aGUgdmFsdWVzIG9mIE1C VUYtDQo+ID4gPmwyX2xlbi8uLi4NCj4gPiA+DQo+ID4gPiBJIGFtIGEgbGl0dGxlIGNvbmZ1c2Vk IGFib3V0IHlvdXIgY29kZSwgc2luY2UgaXQgcGFyc2VzIHBhY2tldCBhbmQNCj4gPiA+IGNoZWNr cyBpZiB0aGUgdmFsdWVzIG9mIE1CVUYtPmwyX2xlbi8uLi4gYXJlIGNvcnJlY3QuIElmIHdlIGRv bid0IHVzZQ0KPiA+ID4gTUJVRi0+bDJfbGVuLy4uLiB0byBnZXQgZXRoZXIvaXB2NC90Y3AgaGVh ZGVycywgd2h5IHNob3VsZCB3ZSBjaGVjaw0KPiA+ID4gdGhlIHZhbHVlcyBvZiBNQlVGLT5sMl9s ZW4vLi4uPw0KPiA+ID4NCj4gPg0KPiA+IEFncmVlIHRoYXQgd2UgZG9uJ3QgbmVlZCBib3RoLg0K PiA+IE15IHByZWZlcmVuY2Ugd291bGQgYmUgdG8gc3RpY2sgd2l0aCAxKS4NCj4gPiBJbiBtYW55 IGNhc2VzIHVzZXIgd291bGQgaGF2ZSBhbHJlYWR5IGRldGVybWluZWQgbDIvbDMvbDQgbGVuDQo+ ID4gYnkgdGhpcyBzdGFnZS4NCj4gPiBLb25zdGFudGluDQo+IA0KPiBEbyB3ZSBoYXZlIGEgZ2Vu ZXJpYyBwYWNrZXQgaGVhZGVyIHZhbGlkYXRpb24gbGlicmFyeT8gT3RoZXJ3aXNlLCB0aGF0DQo+ IHdvdWxkIHBlcmhhcHMgYmUgYSBiZXR0ZXIgcGF0aC4gU3VjaCBhIGxpYnJhcnkgY291bGQgcHJv YmFibHkgdXNlIHNvbWUgb2YNCj4gdGhlIGZsYWdzIGZyb20gdGhlIFBNRCB0byBkZXRlcm1pbmUg aG93IG11Y2ggdG8gdmFsaWRhdGUgaW4gc29mdHdhcmUuDQoNCkFzIGZhciBhcyBJIGtub3csIHdl IGRvbid0IGhhdmUgdGhlIGxpYnJhcnkgdG8gY2hlY2sgaWYgdGhlIHZhbHVlcyBvZiBNQlVGLT5s Ml9sZW4vLi4uDQphcmUgdmFsaWQgb3Igbm90Lg0KDQo+IA0KPiBBbmQgaWYgaXQgaXMgYSBkb2N1 bWVudGVkIHByZWNvbmRpdGlvbiBvZiB0aGUgR1JPIGxpYnJhcnkgdGhhdCBtLQ0KPiA+bDJfbGVu L2wzX2xlbi4uLiBtdXN0IGJlIHNldCBhbmQgc2Vuc2libGUsIHBlcmhhcHMgYW4gUlRFX0FTU0VS VCgpIGNvdWxkDQo+IGJlIGNvbnNpZGVyZWQgaW5zdGVhZCBvZiBncmFjZWZ1bGx5IHJldHVybmlu ZyAtMT8NCg0KQ29tcGFyaW5nIHdpdGggdGVybWluYXRpbmcgdGhlIGFwcGxpY2F0aW9uIGJ5IFJU RV9BU1NFUlQoKSwgSSB0aGluaw0Kbm90IHByb2Nlc3NpbmcgdGhlIGludmFsaWQgcGFja2V0IHdv dWxkIGJlIGEgYmV0dGVyIGNob2ljZS4NCg0KVGhhbmtzLA0KSmlheXUNCg==