From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 07A131150; Sat, 19 Jan 2019 14:31:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2019 05:31:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,495,1539673200"; d="scan'208";a="268376558" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 19 Jan 2019 05:31:58 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 19 Jan 2019 05:31:57 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 19 Jan 2019 05:31:57 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.63]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.85]) with mapi id 14.03.0415.000; Sat, 19 Jan 2019 21:31:55 +0800 From: "Hu, Jiayu" To: Andrew Rybchenko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] gso: fix VxLAN/GRE tunnel checks Thread-Index: AQHUrzHE2W3zX7uKE0STAM7jwBhxNaW2heoA Date: Sat, 19 Jan 2019 13:31:12 +0000 Message-ID: References: <1547818111-21817-1-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1547818111-21817-1-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTU4ZTNkMjktMTlhZi00MWNlLWFkNzUtNmIzMmE1YmYzNDVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibXVQSFNKeUZ4blM5Tk0wN3pvZnp6WVwvWm1oWnlWQkpzVUlSNmVEMjNzYWtydUZOWEgzZVpKeGtaZDl3T2dCK2UifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] gso: fix VxLAN/GRE tunnel checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jan 2019 13:32:01 -0000 Hi Andrew, Would you please give more explanation about the problem that the patch wants to fix? Thanks, Jiayu > -----Original Message----- > From: Andrew Rybchenko [mailto:arybchenko@solarflare.com] > Sent: Friday, January 18, 2019 9:29 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] gso: fix VxLAN/GRE tunnel checks >=20 > Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits. >=20 > Fixes: b058d92ea95d ("gso: support VxLAN GSO") > Fixes: 70e737e448c7 ("gso: support GRE GSO") > Cc: stable@dpdk.org >=20 > Signed-off-by: Andrew Rybchenko > --- > lib/librte_gso/gso_common.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h > index 6cd764ff5..b6ff1b886 100644 > --- a/lib/librte_gso/gso_common.h > +++ b/lib/librte_gso/gso_common.h > @@ -22,12 +22,12 @@ > (PKT_TX_TCP_SEG | PKT_TX_IPV4)) >=20 > #define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG | > PKT_TX_IPV4 | \ > - PKT_TX_OUTER_IPV4 | > PKT_TX_TUNNEL_VXLAN)) =3D=3D \ > + PKT_TX_OUTER_IPV4 | > PKT_TX_TUNNEL_MASK)) =3D=3D \ > (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | > \ > PKT_TX_TUNNEL_VXLAN)) >=20 > #define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG | > PKT_TX_IPV4 | \ > - PKT_TX_OUTER_IPV4 | > PKT_TX_TUNNEL_GRE)) =3D=3D \ > + PKT_TX_OUTER_IPV4 | > PKT_TX_TUNNEL_MASK)) =3D=3D \ > (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | > \ > PKT_TX_TUNNEL_GRE)) >=20 > -- > 2.17.1