From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 09A0E4C91; Mon, 21 Jan 2019 07:40:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2019 22:40:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,502,1539673200"; d="scan'208";a="268662344" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 20 Jan 2019 22:40:52 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 20 Jan 2019 22:40:52 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 20 Jan 2019 22:40:52 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.63]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.71]) with mapi id 14.03.0415.000; Mon, 21 Jan 2019 14:40:50 +0800 From: "Hu, Jiayu" To: Andrew Rybchenko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] gso: fix VxLAN/GRE tunnel checks Thread-Index: AQHUsVJ9oZyGHFCB3ki2M/iKkYYdM6W5Qr5w Date: Mon, 21 Jan 2019 06:40:50 +0000 Message-ID: References: <1547818111-21817-1-git-send-email-arybchenko@solarflare.com> <1548052079-19045-1-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1548052079-19045-1-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWY0NDRkODYtMTE1My00ZjNkLWJjYTYtZTUxN2UzZGJhYmNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid1wvdFRpZUhUTVFobXJqTTYyRzA0VU90QnlOTk5PcGcyckFZT2pNR2JFYVlTWDhuTUtEZktEZUpBYWVhQ3duaGUifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] gso: fix VxLAN/GRE tunnel checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 06:40:54 -0000 > -----Original Message----- > From: Andrew Rybchenko [mailto:arybchenko@solarflare.com] > Sent: Monday, January 21, 2019 2:28 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH v2] gso: fix VxLAN/GRE tunnel checks >=20 > Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits. > As the result, for example, IPIP or MPLSinUDP tunnel packets may be > incorrected treated internally as VXLAN. There is a typo: 'incorrected' -> 'incorrectly'. Thanks, Jiayu >=20 > Fixes: b058d92ea95d ("gso: support VxLAN GSO") > Fixes: 70e737e448c7 ("gso: support GRE GSO") > Cc: stable@dpdk.org >=20 > Signed-off-by: Andrew Rybchenko > --- > lib/librte_gso/gso_common.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h > index 6cd764ff5..b6ff1b886 100644 > --- a/lib/librte_gso/gso_common.h > +++ b/lib/librte_gso/gso_common.h > @@ -22,12 +22,12 @@ > (PKT_TX_TCP_SEG | PKT_TX_IPV4)) >=20 > #define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG | > PKT_TX_IPV4 | \ > - PKT_TX_OUTER_IPV4 | > PKT_TX_TUNNEL_VXLAN)) =3D=3D \ > + PKT_TX_OUTER_IPV4 | > PKT_TX_TUNNEL_MASK)) =3D=3D \ > (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | > \ > PKT_TX_TUNNEL_VXLAN)) >=20 > #define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG | > PKT_TX_IPV4 | \ > - PKT_TX_OUTER_IPV4 | > PKT_TX_TUNNEL_GRE)) =3D=3D \ > + PKT_TX_OUTER_IPV4 | > PKT_TX_TUNNEL_MASK)) =3D=3D \ > (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | > \ > PKT_TX_TUNNEL_GRE)) >=20 > -- > 2.17.1