From: "Hu, Jiayu" <jiayu.hu@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] gso: fix VxLAN/GRE tunnel checks
Date: Mon, 21 Jan 2019 06:45:23 +0000 [thread overview]
Message-ID: <ED946F0BEFE0A141B63BABBD629A2A9B3CF486F2@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1548052958-9943-1-git-send-email-arybchenko@solarflare.com>
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Monday, January 21, 2019 2:43 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH v3] gso: fix VxLAN/GRE tunnel checks
>
> Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
> As the result, for example, IPIP or MPLSinUDP tunnel packets may be
> incorrectly treated internally as VXLAN.
>
> Fixes: b058d92ea95d ("gso: support VxLAN GSO")
> Fixes: 70e737e448c7 ("gso: support GRE GSO")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> lib/librte_gso/gso_common.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
> index 6cd764ff5..b6ff1b886 100644
> --- a/lib/librte_gso/gso_common.h
> +++ b/lib/librte_gso/gso_common.h
> @@ -22,12 +22,12 @@
> (PKT_TX_TCP_SEG | PKT_TX_IPV4))
>
> #define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> - PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_VXLAN)) == \
> + PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) == \
> (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
> PKT_TX_TUNNEL_VXLAN))
>
> #define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> - PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_GRE)) == \
> + PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) == \
> (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
> PKT_TX_TUNNEL_GRE))
>
> --
> 2.17.1
Acked-by: Jiayu Hu <jiayu.hu@intel.com>
next prev parent reply other threads:[~2019-01-21 6:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 13:28 [dpdk-dev] [PATCH] " Andrew Rybchenko
2019-01-19 13:31 ` Hu, Jiayu
2019-01-20 9:58 ` Andrew Rybchenko
2019-01-20 13:27 ` Hu, Jiayu
2019-01-21 6:27 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2019-01-21 6:40 ` Hu, Jiayu
2019-01-21 6:42 ` [dpdk-dev] [PATCH v3] " Andrew Rybchenko
2019-01-21 6:45 ` Hu, Jiayu [this message]
2019-01-22 16:09 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED946F0BEFE0A141B63BABBD629A2A9B3CF486F2@shsmsx102.ccr.corp.intel.com \
--to=jiayu.hu@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).