From: "Long, Thomas" <thomas.long@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Xie, Huawei" <huawei.xie@intel.com>,
"Ouyang, Changchun" <changchun.ouyang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: enable live migration
Date: Tue, 9 Jun 2015 04:31:06 +0000 [thread overview]
Message-ID: <EDCDDC5F3D468742B7A0048DF6854261448774F8@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <1506243.eodKRb0EkH@xps13>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Thursday, June 4, 2015 2:00 PM
> To: Xie, Huawei
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] vhost: enable live migration
> 2015-06-01 04:47, Ouyang, Changchun:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Huawei Xie
> > > When we migrate VM, without this feature, qemu will report error :
> > > "migrate: Migration disabled: vhost lacks VHOST_F_LOG_ALL feature".
> >
> > Is this enough for vhost to support migrate VM?
> > I remember Claire has another patch, possibly need refer to that patch.
> Indeed, there were some patches which do not build:
> http://dpdk.org/ml/archives/dev/2014-August/005050.html
> And there was no answer.
The log name is incorrect in Claire's patch and "CONFIG" needs to replaced with "VHOST_CONFIG". It also only supported migration for vhost_cuse. Claire left the org around the same time and the patch was not picked up
> [...]
> > > + (1ULL << VHOST_F_LOG_ALL))
> Please check if this line is sufficient.
This should be sufficient to enable migration for vhost-user.
The previous patch with the CONFIG log fix enables migration for vhost-cuse. The behavior of qemu with vhost_cuse when migrating is to turn on the migration flag before migration regardless of what the backend advertises as being supported and to disable it again once migration has been completed. This is why Claire's patch ignores the VHOST_F_LOG_ALL setting although I don't think this is the right way to implement this. If the current patch is combined with the vhost_net_ioctl modifications of the original patch then it should enable migration for both vhost-cuse and vhost-user.
> Thanks
next prev parent reply other threads:[~2015-06-09 4:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 3:01 Huawei Xie
2015-06-01 4:47 ` Ouyang, Changchun
2015-06-04 13:00 ` Thomas Monjalon
2015-06-09 4:31 ` Long, Thomas [this message]
2015-06-12 15:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EDCDDC5F3D468742B7A0048DF6854261448774F8@IRSMSX106.ger.corp.intel.com \
--to=thomas.long@intel.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).