From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 373581DB1 for ; Tue, 9 Jun 2015 06:31:10 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 08 Jun 2015 21:31:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,577,1427785200"; d="scan'208";a="723590532" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga001.fm.intel.com with ESMTP; 08 Jun 2015 21:31:09 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.76]) by IRSMSX109.ger.corp.intel.com ([169.254.13.51]) with mapi id 14.03.0224.002; Tue, 9 Jun 2015 05:31:08 +0100 From: "Long, Thomas" To: Thomas Monjalon , "Xie, Huawei" , "Ouyang, Changchun" Thread-Topic: [dpdk-dev] [PATCH] vhost: enable live migration Thread-Index: AQHQnsZiT08no0lEMkG8nUJf0LEf+Z2jmC1Q Date: Tue, 9 Jun 2015 04:31:06 +0000 Message-ID: References: <1432695691-22360-1-git-send-email-huawei.xie@intel.com> <1506243.eodKRb0EkH@xps13> In-Reply-To: <1506243.eodKRb0EkH@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] vhost: enable live migration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 04:31:10 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, June 4, 2015 2:00 PM > To: Xie, Huawei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: enable live migration > 2015-06-01 04:47, Ouyang, Changchun: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Huawei Xie > > > When we migrate VM, without this feature, qemu will report error : > > > "migrate: Migration disabled: vhost lacks VHOST_F_LOG_ALL feature". > >=20 > > Is this enough for vhost to support migrate VM? > > I remember Claire has another patch, possibly need refer to that patch. > Indeed, there were some patches which do not build: > http://dpdk.org/ml/archives/dev/2014-August/005050.html > And there was no answer. The log name is incorrect in Claire's patch and "CONFIG" needs to replaced = with "VHOST_CONFIG". It also only supported migration for vhost_cuse. Clair= e left the org around the same time and the patch was not picked up > [...] > > > + (1ULL << VHOST_F_LOG_ALL)) > Please check if this line is sufficient. This should be sufficient to enable migration for vhost-user.=20 The previous patch with the CONFIG log fix enables migration for vhost-cuse= . The behavior of qemu with vhost_cuse when migrating is to turn on the mig= ration flag before migration regardless of what the backend advertises as b= eing supported and to disable it again once migration has been completed. T= his is why Claire's patch ignores the VHOST_F_LOG_ALL setting although I do= n't think this is the right way to implement this. If the current patch is= combined with the vhost_net_ioctl modifications of the original patch then= it should enable migration for both vhost-cuse and vhost-user.=20 > Thanks