DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Chi, Xiaobo (Nokia - CN/Hangzhou)" <xiaobo.chi@nokia.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] [dpdk_dev]bug report: create_proc_read_entry() is not supported from linux kernel 3.10.x
Date: Wed, 5 Aug 2015 08:26:58 +0000	[thread overview]
Message-ID: <EF703E8970265941A1316EEFE0AA7B6C412C4FDF@SGSIMBX004.nsn-intra.net> (raw)

Hi,
Anyone has ever tested the rte_kni.ko in igb mode?  If the following is confirmed as a bug, I would like to work out a patch. Thanks.
For file ~/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/ igb_procfs.c, there are following code. As to what I know, from Linux kernel 3.10.x, the functions create_proc_read_entry() and create_proc_entry() are not supported anymore, so we should use proc_create_data() for compatibility for both kernel 2.6 and 3.10.x and later versions.

/* called from igb_main.c */
int igb_procfs_init(struct igb_adapter *adapter)
{
......................
        for (index = 0; ; index++) {
                if (igb_proc_entries[index].read == NULL) {
                        break;
                }
                if (!(create_proc_read_entry(igb_proc_entries[index].name,
                                           0444,
                                           adapter->info_dir,
                                           igb_proc_entries[index].read,
                                           adapter))) {

                        rc = -ENOMEM;
                        goto fail;
                }
        }
......................
}

root@distro:~$ uname -a
Linux distro 3.18.9-pc64-distro.git-v1.7 #1 SMP Thu May 7 12:30:41 UTC 2015 x86_64 GNU/Linux
root@distro:~$ cat /proc/kallsyms | grep create_proc_read_entry
root@distro:~$ cat /proc/kallsyms | grep proc_create_data
ffffffff803e1fd0 T proc_create_data
ffffffff80a30dd0 R __ksymtab_proc_create_data
ffffffff80a4738a r __kstrtab_proc_create_data
root@distro:~$

brgs,
chi Xiaobo

             reply	other threads:[~2015-08-05  8:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05  8:26 Chi, Xiaobo (Nokia - CN/Hangzhou) [this message]
2015-08-14  8:55 ` Chi, Xiaobo (Nokia - CN/Hangzhou)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EF703E8970265941A1316EEFE0AA7B6C412C4FDF@SGSIMBX004.nsn-intra.net \
    --to=xiaobo.chi@nokia.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).