DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Boyer <aboyer@pensando.io>
To: dev@dpdk.org
Subject: [dpdk-dev] Q about testpmd and link speed settings
Date: Wed, 25 Nov 2020 15:55:11 -0500
Message-ID: <F041DE53-0ABF-4A0A-974A-16167967ABD5@pensando.io> (raw)

Almost every PMD seems to do something like this (igb in this example):

	autoneg = (*speeds & ETH_LINK_SPEED_FIXED) == 0;

But testpmd’s parse_and_check_speed_duplex() doesn’t ever set the FIXED bit. It either sets AUTONEG (0) or the bit for one of the individual speeds.

Thus when I run a testpmd command like this:

	testpmd> port config all speed 100000 duplex full

The PMD gets a speed setting in eth_dev->data->dev_conf->link_speeds, but it doesn’t have the FIXED bit set.

The patch below corrects this behavior for me. For some reason it breaks the testpmd link_bonding_autotest though - does anyone with an understanding of the internals of the unit tests care to take a look at why?

	+ TestCase [51] : test_tlb_verify_promiscuous_enable_disable succeeded
	+ TestCase [52] : test_tlb_verify_slave_link_status_change_failover failed
	Port 8 must be stopped to allow configuration
	+ TestCase [53] : test_alb_change_mac_in_reply_sent failed
	Port 8 must be stopped to allow configuration
	+ TestCase [54] : test_alb_reply_from_client failed
	Port 8 must be stopped to allow configuration
	+ TestCase [55] : test_alb_receive_vlan_reply failed
	Port 8 must be stopped to allow configuration
	+ TestCase [56] : test_alb_ipv4_tx failed 

Does this sound reasonable or am I way off track?

Thank you,
Andrew

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index a037a55c6a..075804b8b5 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1627,6 +1627,9 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed)
                }
        }
 
+       if (*speed != ETH_LINK_SPEED_AUTONEG)
+               *speed |= ETH_LINK_SPEED_FIXED;
+
        return 0;
 }




             reply	other threads:[~2020-11-25 20:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 20:55 Andrew Boyer [this message]
2020-12-09 19:32 ` Andrew Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F041DE53-0ABF-4A0A-974A-16167967ABD5@pensando.io \
    --to=aboyer@pensando.io \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git