From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) by dpdk.org (Postfix) with ESMTP id 6EC5F2C16 for ; Fri, 22 Apr 2016 07:58:26 +0200 (CEST) Received: by mail-lf0-f51.google.com with SMTP id g184so73219974lfb.3 for ; Thu, 21 Apr 2016 22:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7cmZJAcbhrfxEq7w+GnassIiM6Y5k054IfDN2sN0BWc=; b=nFe+7ucCPQAgPEYjtV/A4ES/wPliA8nnCo6Io01d0UT4wWzpcQi/Y45xozQeStQO3g vZCobl83JYNaaITVZS2mVgP59qBZ/FK1k3BfLH93Yf0lIpfsJ1IB7BEUxjgeqlXk6rWt /xeL7OwSJ6rwpRk8aLT00N5mSmPCfsjWHqkas23tbUCRigDEud5Z4X52Nc+5q/bnCCwI nwt3VC0duHLbtaLOXuP4fG/G15p1PDzrS+bGEMWdt1lrpfWHAGliW4Yudpv30hQKPNgs 555nyBqiU1iSOWB9DKKVEM+gm1wsl8P0w7mOEm/jAE+d147/d4hk1wUEPEJzhU9K6LHZ Ob3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7cmZJAcbhrfxEq7w+GnassIiM6Y5k054IfDN2sN0BWc=; b=NJ3hsPRgfjm5q2xBs29Cr5n2/F3fcmWPL4JcW3a9NJTXU7XcGhNRx/7/czuVRCFX8x 7HIdzT9c9qz6pa0fFOu6x9HHpxjoaiaEdggNjymNi3tmJy9M59HzYdqNKrI3FbXWQFTL GbNp64dcuZF9RswpTZwLRTpGpbN9jafqUSD+IeTsaiFM2f33bRiPLzCY0cPZJ5tVOl8M CifvdpRwdtspHutcRf80i7r11iDuM/Wppo3kSg24KN8eVbOlzjvu/VeoRyDVY2bpjm40 nm7iIp7cGGZnXEt0jLkAGsfohVSnORofba1jaRAU5Sa9HCLoKVWqV6G4/t7vJhq+W8v0 mLDg== X-Gm-Message-State: AOPr4FVE4A3EzRjfdHL82fl8T2zLEdMX5dZCIEGJ8Onb9pB8KTMF/06U7nB8hqqreRjSQQ== X-Received: by 10.25.146.65 with SMTP id u62mr163642lfd.121.1461304706036; Thu, 21 Apr 2016 22:58:26 -0700 (PDT) Received: from [192.168.0.48] ([77.105.154.246]) by smtp.gmail.com with ESMTPSA id s63sm1218966lfs.17.2016.04.21.22.58.25 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Apr 2016 22:58:25 -0700 (PDT) Mime-Version: 1.0 (1.0) From: Igor Ryzhov X-Mailer: iPhone Mail (13E238) In-Reply-To: Date: Fri, 22 Apr 2016 08:58:24 +0300 Cc: Sergey Balabanov , "dev@dpdk.org" Message-Id: References: <1440767187-19120-1-git-send-email-balabanovsv@ecotelecom.ru> <27DE54DB-C30D-4395-BE26-089622582178@nfware.com> To: "Zhang, Helin" Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] kni: set kni mac on ioctl_create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 05:58:26 -0000 v2 is here, sorry: http://www.dpdk.org/dev/patchwork/patch/12190/. > 22 =C1=D0=D2. 2016 =C7., =D7 4:57, Zhang, Helin =CE= =C1=D0=C9=D3=C1=CC(=C1): >=20 >=20 >=20 > From: Igor Ryzhov [mailto:iryzhov@nfware.com]=20 > Sent: Thursday, April 21, 2016 11:16 PM > To: Zhang, Helin > Cc: Sergey Balabanov; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kni: set kni mac on ioctl_create >=20 > Hello. >=20 > I rebased a patch and added Suggested-by string. > Check it, please: http://dpdk.org/dev/patchwork/patch/12188/. > [Helin] is that the v2 version? It seems that I cannot find that. >=20 > Best regards, > Igor >=20 > 18 =CD=C1=D2=D4=C1 2016 =C7., =D7 5:14, Zhang, Helin =CE=C1=D0=C9=D3=C1=CC(=C1): >=20 > Hi Sergey >=20 >=20 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergey Balabanov > Sent: Friday, August 28, 2015 9:06 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] kni: set kni mac on ioctl_create >=20 > There is a situation when ioctl returns zero mac address (00:00:00:00:00:0= 0) > for just created kni. The situation happens because kni mac is set on 'ipc= onfig > up' event (kni_net_open callback) not on kni creation (kni_ioctl_create). > Could you help to clarify a bit of the real issue? What's wrong there? >=20 >=20 >=20 > Signed-off-by: Sergey Balabanov > --- > lib/librte_eal/linuxapp/kni/kni_misc.c | 10 ++++++++++ > lib/librte_eal/linuxapp/kni/kni_net.c | 9 --------- > 2 files changed, 10 insertions(+), 9 deletions(-) >=20 > diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c > b/lib/librte_eal/linuxapp/kni/kni_misc.c > index 2e9fa89..61f83a0 100644 > --- a/lib/librte_eal/linuxapp/kni/kni_misc.c > +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include /* eth_type_trans */ >=20 > #include > #include "kni_dev.h" > @@ -465,6 +466,15 @@ kni_ioctl_create(unsigned int ioctl_num, unsigned > long ioctl_param) > if (pci) > pci_dev_put(pci); >=20 > + if (kni->lad_dev) > + memcpy(net_dev->dev_addr, kni->lad_dev->dev_addr, > ETH_ALEN); > + else > + /* > + * Generate random mac address. eth_random_addr() is the > newer > + * version of generating mac address in linux kernel. > + */ > + random_ether_addr(net_dev->dev_addr); > + > A rebase is needed, as a lot of changes after that. Thanks! >=20 > Helin >=20 > ret =3D register_netdev(net_dev); > if (ret) { > KNI_ERR("error %i registering device \"%s\"\n", diff --git > a/lib/librte_eal/linuxapp/kni/kni_net.c b/lib/librte_eal/linuxapp/kni/kni_= net.c > index ab5add4..b50b4cf 100644 > --- a/lib/librte_eal/linuxapp/kni/kni_net.c > +++ b/lib/librte_eal/linuxapp/kni/kni_net.c > @@ -70,15 +70,6 @@ kni_net_open(struct net_device *dev) > struct rte_kni_request req; > struct kni_dev *kni =3D netdev_priv(dev); >=20 > - if (kni->lad_dev) > - memcpy(dev->dev_addr, kni->lad_dev->dev_addr, > ETH_ALEN); > - else > - /* > - * Generate random mac address. eth_random_addr() is the > newer > - * version of generating mac address in linux kernel. > - */ > - random_ether_addr(dev->dev_addr); > - > netif_start_queue(dev); >=20 > memset(&req, 0, sizeof(req)); > -- > 2.1.4 >=20