From: Dharmik Thakkar <Dharmik.Thakkar@arm.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: David Marchand <david.marchand@redhat.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
"Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>, dev <dev@dpdk.org>,
nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [RFC] rcu: build on Windows
Date: Tue, 20 Oct 2020 12:51:14 +0000 [thread overview]
Message-ID: <F23E58D6-90D5-4894-B580-74446DDF0212@arm.com> (raw)
In-Reply-To: <20201020113443.694de796@sovereign>
> On Oct 20, 2020, at 3:34 AM, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> On Tue, 20 Oct 2020 10:13:11 +0200, David Marchand wrote:
>> On Tue, Oct 20, 2020 at 1:34 AM Dharmik Thakkar <dharmik.thakkar@arm.com> wrote:
>>>
>>> Build the lib for Windows.
>>>
>>> Change-Id: Ib83431a9ee56a7b38445f0474cb9a12b17cf18f9
>>> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
>>> ---
>>> lib/meson.build | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/lib/meson.build b/lib/meson.build
>>> index dd55b5cb53e4..1bb019720c6a 100644
>>> --- a/lib/meson.build
>>> +++ b/lib/meson.build
>>> @@ -41,6 +41,7 @@ if is_windows
>>> 'telemetry',
>>> 'eal',
>>> 'ring',
>>> + 'rcu',
>>> 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci',
>>> 'cmdline',
>>> 'hash',
>>> --
>>> 2.17.1
>>>
>>
>> If we skip the new failures in Intel CI due to kni build being broken,
>> I see that Windows build is fine but I have no log of it.
>> UNH lab skipped testing this patch, as it is a RFC (iiuc).
>> We need more tests, but on the principle, what do you think about enabling rcu?
>
> Builds OK with Linux/GCC (cross), Windows/MinGW-w64, Windows/clang.
>
> Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Thank you for testing, Dmitry!
I tried cross-compilation on Linux (Ubuntu 18.04) with MinGW-w64 toolchain, but I am seeing some compilation error:
../lib/librte_eal/common/eal_common_dev.c: In function ‘rte_dev_probe’:
../lib/librte_eal/common/eal_common_dev.c:215:12: error: ‘ENOMSG’ undeclared (first use in this function); did you mean ‘NPMSG’?
return -ENOMSG;
^~~~~~
NPMSG
../lib/librte_eal/common/eal_common_dev.c:215:12: note: each undeclared identifier is reported only once for each function it appears in
../lib/librte_eal/common/eal_common_dev.c: In function ‘rte_dev_remove’:
../lib/librte_eal/common/eal_common_dev.c:361:12: error: ‘ENOMSG’ undeclared (first use in this function); did you mean ‘NPMSG’?
return -ENOMSG;
^~~~~~
NPMSG
[52/178] Compiling C object 'lib/lib@@rte_eal@sta/librte_eal_windows_eal_memory.c.obj'.
ninja: build stopped: subcommand failed.
Any help is appreciated.
next prev parent reply other threads:[~2020-10-20 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 23:33 Dharmik Thakkar
2020-10-20 8:13 ` David Marchand
2020-10-20 8:34 ` Dmitry Kozlyuk
2020-10-20 12:51 ` Dharmik Thakkar [this message]
2020-10-20 15:40 ` Honnappa Nagarahalli
2020-10-20 15:52 ` Dmitry Kozlyuk
2020-10-20 16:37 ` Dharmik Thakkar
2020-10-20 17:15 ` Ranjit Menon
2020-10-20 12:43 ` Dharmik Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F23E58D6-90D5-4894-B580-74446DDF0212@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=nd@arm.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).