From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0057.outbound.protection.outlook.com [104.47.2.57]) by dpdk.org (Postfix) with ESMTP id 3A6AD5F29 for ; Wed, 7 Mar 2018 22:36:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=um3dLOhKX6QyN8sUkrMm5ipg8f2cjjJ4FYihRBwypSs=; b=DJcw+wpgFSFbGsIBW6/tOp4Xet6tj7hfEdxCjfDstkOfvP8+jm5+6RHIPw3edD0YWVtCZQzm4xlkPkS5VTdbEIhMCgudOFViTCBJmpFpLd1zOPXtOAiiCBdkkxst/uF2Vc8SRfNvPQzVKr+oFD2tiIalGi9HU0445njbAqoOZyY= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2112.eurprd05.prod.outlook.com (10.167.196.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Wed, 7 Mar 2018 21:36:47 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::59c:947c:846:ff92]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::59c:947c:846:ff92%13]) with mapi id 15.20.0548.016; Wed, 7 Mar 2018 21:36:46 +0000 From: Yongseok Koh To: Ferruh Yigit CC: Wenzhuo Lu , Jingjing Wu , "dev@dpdk.org" , Shahaf Shuler Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: print Rx/Tx offload values Thread-Index: AQHTtWgz1MLABU1oWUGQ8XCLirtelaPFTfeA Date: Wed, 7 Mar 2018 21:36:46 +0000 Message-ID: References: <20180306162822.61791-1-ferruh.yigit@intel.com> In-Reply-To: <20180306162822.61791-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2112; 7:d9Bseuja537Pnteu89O32ge1n35FVc6Ata8OMZupnAOgBQ9gGDmSn0kqgkbaNzK/7uxTbAo6UiNHU6YLF7A2fvoHSs6Bd/tJhIBQzfDrtbYEaS/2It6YjyEB1PsXDm9lalrV36g6HwZgf1sXONTtQJsaKh1NMsLM6m0uKOEzwI/p0RmPTjO9cZPC08KTpFgA9JiOm5CWXjgo5fDckPqn6BWOzr7+fUOQMH2EgjoxqPPT7UitIWOWSYwzeNK8yZfh x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7f0657b3-e538-441c-b112-08d584738750 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2112; x-ms-traffictypediagnostic: VI1PR0501MB2112: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231220)(944501244)(52105095)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR0501MB2112; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2112; x-forefront-prvs: 0604AFA86B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(39860400002)(39380400002)(346002)(376002)(199004)(189003)(6486002)(53936002)(186003)(575784001)(36756003)(8936002)(6436002)(6512007)(8676002)(54906003)(3280700002)(14454004)(2900100001)(33656002)(478600001)(83716003)(5660300001)(4326008)(86362001)(26005)(7736002)(316002)(305945005)(3660700001)(99286004)(105586002)(107886003)(6246003)(76176011)(229853002)(2906002)(68736007)(6506007)(102836004)(6916009)(2950100002)(3846002)(6116002)(106356001)(66066001)(81166006)(97736004)(25786009)(82746002)(81156014)(59450400001)(53546011)(5250100002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2112; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: nNR9x1i0MUkSv9kEuTeX/qC7D5mTWv4eObaBWDM4o5JNv+o9BDAetE/9Jbq+mjGaTDSw8wYqOFMrvA/BTTQ0/fIJn0nu4m/4tg1KLzrAfOT6vu0tY/7TujA62WQvCLN/UpoRvuV6yLpfjhDHTolP9FLzMTgoVT0C44ibPXMPl03Nl39wGq5bjoLV1ki01RcuCvCiAk4c5eZioX4IJ3Gc23BTGAS5WeP8OYMfIVSefZ8553Yc6eWAnZQ5d2e2LpjjWJJtEtzZQTdS4RoTvxYAaR6rseAqe+HsjRcQHE6LjuNe2h006cyFn9vfA+DS1IBY6AIoLNId5XWwspnzwJE2kQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <03136AAB1572A749A59FD10B9D324730@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f0657b3-e538-441c-b112-08d584738750 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2018 21:36:46.7704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2112 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: print Rx/Tx offload values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 21:36:50 -0000 > On Mar 6, 2018, at 8:28 AM, Ferruh Yigit wrote: >=20 > It is not clear which per port offloads are enabled. Printing offloads > values at forwarding start. >=20 > CRC strip offload value was printed in more verbose manner, it is > removed since Rx/Tx offload values covers it and printing only CRC one > can cause confusion. >=20 > Hexadecimal offloads values are not very user friendly but preferred to > not create to much noise during forwarding start. >=20 > Signed-off-by: Ferruh Yigit > --- > Cc: Shahaf Shuler > --- > app/test-pmd/config.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 4bb255c62..47845d0cb 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1682,10 +1682,9 @@ rxtx_config_display(void) > struct rte_eth_txconf *tx_conf =3D &ports[pid].tx_conf; >=20 > printf(" port %d:\n", (unsigned int)pid); > - printf(" CRC stripping %s\n", > - (ports[pid].dev_conf.rxmode.offloads & > - DEV_RX_OFFLOAD_CRC_STRIP) ? > - "enabled" : "disabled"); > + printf(" Rx offloads=3D0x%"PRIx64" Tx Offloads=3D0x%"PRIx64"\n", > + ports[pid].dev_conf.rxmode.offloads, > + ports[pid].dev_conf.txmode.offloads); So, if someone wants to know what these values mean, they should type 'show port cap all'. BTW, tx_conf->offloads is printed a few lines later, then isn't it necessar= y to print rx_conf->offloads as well? Or, is it supposed to be identical to dev_conf.rxmode.offloads? Thanks, Yongseok=