From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5FF43AFD6 for ; Wed, 18 Jun 2014 10:51:17 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 18 Jun 2014 01:51:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,499,1400050800"; d="scan'208";a="530331539" Received: from fmsmsx104.amr.corp.intel.com ([10.19.9.35]) by orsmga001.jf.intel.com with ESMTP; 18 Jun 2014 01:51:32 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX104.amr.corp.intel.com (10.19.9.35) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 18 Jun 2014 01:51:08 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.122]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.209]) with mapi id 14.03.0123.003; Wed, 18 Jun 2014 16:51:02 +0800 From: "Zhang, Helin" To: Thomas Monjalon , "Chen, Jing D" Thread-Topic: [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support Thread-Index: AQHPikkozbdvWR0ayUmWdsBH34f0Fpt2j3yQ Date: Wed, 18 Jun 2014 08:51:02 +0000 Message-ID: References: <1401944951-23783-1-git-send-email-helin.zhang@intel.com> <3908766.ykkJEPOGFU@xps13> In-Reply-To: <3908766.ykkJEPOGFU@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2014 08:51:17 -0000 -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Wednesday, June 18, 2014 12:28 AM To: Zhang, Helin; Chen, Jing D Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support > The 2nd version of series of patches are to add i40e PMD support. > It contains the updated basic shared code, and some other enhancements. > It adds the support of the latest version of firmware. > * Add new PMD driver of i40e in the folder of librte_pmd_i40e > * Add some neccessary definitions, changes in rte_mbuf.h and eth_dev > * Add new configurations for i40e > * Add or modifiy makefiles to support i40e compilation > * Add neccessary changes in ixgbe, e1000 and vmxnet3 PMD, as hash flags > has been enlarged from 16 bits to 64 bits to support i40e > * Add neccessary changes in example applications and testpmd to use > ETH_RSS_IP to replace all IP hash flags, as i40e introduced more > hash flags. > * Add command in testpmd for port based vlan insertion offload testing > * Add neccessary changes in eth_dev to support configuring maximum > packet length of less than 1518 > * Add two sys files in igb_uio to support enabling/disabling > 'Extended Tag' and resetting 'Max Read Request Size', as it has > big impacts on i40e performance > * Add neccessary changes in pci to read/write the above two sys files > during probing PCI >=20 > Features/enhancements to be implemented later: > * Set link speed, and physically up/down > * Double VLAN support, flow director, VMDq and DCB > * VLAN insertion/stripping, RSS in VF >=20 > Signed-off-by: Helin Zhang > Signed-off-by: Jing Chen > Acked-by: Cunming Liang > Acked-by: Jijiang Liu > Acked-by: Jingjing Wu > Acked-by: Heqing Zhu > Tested-by: Waterman Cao Applied for version 1.7.0. Some things could be cleaned up later, especially i40e specific flags in ge= neric API must be removed. Please work on a patch for next release. Thanks for the hard work -- Thomas ---------------------------------------------------------------------------= --------- Hi Thomas Thank you greatly to merge those code! Btw, what do you mean the i40e specific flags in generic API? Did you mean = the new flags defined in rte_mbuf.h? Yes, we are working on some bug fixes and enhancements which might need to = be added in the next release. Hopefully we can see them soon. Regards, Helin