From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 78BE82A7 for ; Thu, 19 Jun 2014 08:24:33 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 18 Jun 2014 23:19:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,505,1400050800"; d="scan'208";a="559955014" Received: from fmsmsx103.amr.corp.intel.com ([10.19.9.34]) by orsmga002.jf.intel.com with ESMTP; 18 Jun 2014 23:24:48 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.19.9.34) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 18 Jun 2014 23:24:48 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 18 Jun 2014 23:24:48 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.122]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.210]) with mapi id 14.03.0123.003; Thu, 19 Jun 2014 14:24:46 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support Thread-Index: AQHPikkozbdvWR0ayUmWdsBH34f0Fpt2j3yQ//+D4oCAAeV2cA== Date: Thu, 19 Jun 2014 06:24:45 +0000 Message-ID: References: <1401944951-23783-1-git-send-email-helin.zhang@intel.com> <3908766.ykkJEPOGFU@xps13> <1886490.uKY7E5th3Z@xps13> In-Reply-To: <1886490.uKY7E5th3Z@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jun 2014 06:24:34 -0000 -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Wednesday, June 18, 2014 5:24 PM To: Zhang, Helin Cc: Chen, Jing D; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support 2014-06-18 08:51, Zhang, Helin: > Thomas Monjalon: > > Some things could be cleaned up later, especially i40e specific=20 > > flags in generic API must be removed. Please work on a patch for next r= elease. >=20 > Btw, what do you mean the i40e specific flags in generic API? Did you=20 > mean the new flags defined in rte_mbuf.h? Yes, we are working on some=20 > bug fixes and enhancements which might need to be added in the next relea= se. I mean that RSS flags are really Intel-specific. In case other NIC vendors = would use this RSS API, it can be a problem to address. But we can wait for= this one. About mbuf flags, they are all zeros and useless. So a patch is needed to g= et some space and define new values (as you already explained). And last but not the least, RTE_LIBRTE_I40E_16BYTE_RX_DESC handling is very= strange as it can be seen in this commit: http://dpdk.org/browse/dpdk/commit/?id=3Dac2ece3fb1f5511 --=20 Thomas -------------------------------------------------------------------------- Hi Thomas I am now working on several small bug fixes and enhancements which is for t= he next rc, including the rework of the last item you indicated in testpmd.= Thank you very much! Regards, Helin