From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 31E2747D2 for ; Mon, 23 Jun 2014 04:20:54 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 22 Jun 2014 19:15:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,527,1400050800"; d="scan'208";a="532460667" Received: from fmsmsx105.amr.corp.intel.com ([10.19.9.36]) by orsmga001.jf.intel.com with ESMTP; 22 Jun 2014 19:21:08 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.19.9.53) by FMSMSX105.amr.corp.intel.com (10.19.9.36) with Microsoft SMTP Server (TLS) id 14.3.123.3; Sun, 22 Jun 2014 19:21:08 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX102.amr.corp.intel.com (10.19.9.53) with Microsoft SMTP Server (TLS) id 14.3.123.3; Sun, 22 Jun 2014 19:21:07 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.122]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.81]) with mapi id 14.03.0123.003; Mon, 23 Jun 2014 10:21:06 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 3/7] i40e: ignore the failure of updating default filter settings Thread-Index: AQHPjJJJyc/XeYqg2E2pbDighFv9ipt9+LFA Date: Mon, 23 Jun 2014 02:21:03 +0000 Message-ID: References: <1403244889-21358-1-git-send-email-helin.zhang@intel.com> <1403244889-21358-4-git-send-email-helin.zhang@intel.com> <5591358.CZJT0GNYNp@xps13> In-Reply-To: <5591358.CZJT0GNYNp@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 3/7] i40e: ignore the failure of updating default filter settings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jun 2014 02:20:55 -0000 -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Friday, June 20, 2014 10:16 PM To: Zhang, Helin Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/7] i40e: ignore the failure of updating de= fault filter settings 2014-06-20 14:14, Helin Zhang: > The failure of updating the default filter setting should be ignored.=20 > The updating is to change the default vlan filter behaviours=20 > configured by firmware to expected. > The failure happens on the firmware version of 4.2.2, while doesn't=20 > happen on previous versions, as the default settings of firmware=20 > changed. [...] > ret =3D i40e_update_default_filter_setting(vsi); > - if (ret !=3D I40E_SUCCESS) { > - PMD_DRV_LOG(ERR, "Failed to remove default " > - "filter setting\n"); > - goto fail_msix_alloc; > - } > - } > - else if (type =3D=3D I40E_VSI_SRIOV) { > + if (ret !=3D I40E_SUCCESS) > + PMD_DRV_LOG(ERR, "Failure of removing default filter " > + "setting can be ignored\n"); > + /** > + * The failure of updating default filter setting > + * can be ignored > + */ > + } else if (type =3D=3D I40E_VSI_SRIOV) { The log is not clear and the log message doesn't include firmware explanati= on.=20 Please reword. By the way, there is already a log message in the function: PMD_DRV_LOG(WARNING, "Failed to remove default [mac,vlan] config\n"); http://dpdk.org/browse/dpdk/commit/?id=3D9d7d8513b587d32b8f66 Will we see these error messages each time we configure an i40e device? I think it's strange to have a log message saying it can be ignored. Can it be a real error in some cases? -- Thomas ---------------------------------------------------------------------------= ------------------------------------------------- Hi Thomas For recently firmware 4.2.2, the removing default macvlan filter will alway= s fail during initialization. It is not an error. For old firmware versions, the firmwares load a default macvlan filter whic= h has wrong configurations, it needs to remove the default one and reload a= macvlan filter with correct configurations. So the return value at that moment should be ignored. I will write more det= ailed annotations to describe the issue and why we need it, and delete logs= to prevent confusing users. Regards, Helin