From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id F41AF47D2 for ; Mon, 23 Jun 2014 04:29:22 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 22 Jun 2014 19:29:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,527,1400050800"; d="scan'208";a="532463144" Received: from fmsmsx104.amr.corp.intel.com ([10.19.9.35]) by orsmga001.jf.intel.com with ESMTP; 22 Jun 2014 19:29:39 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.19.17.220) by FMSMSX104.amr.corp.intel.com (10.19.9.35) with Microsoft SMTP Server (TLS) id 14.3.123.3; Sun, 22 Jun 2014 19:29:38 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.19.17.220) with Microsoft SMTP Server (TLS) id 14.3.123.3; Sun, 22 Jun 2014 19:29:38 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.122]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.36]) with mapi id 14.03.0123.003; Mon, 23 Jun 2014 10:29:36 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 2/7] i40evf: support configuring crc stripping hw offload Thread-Index: AQHPjJE7CBUBlitd7kCJTXKN3Hfdopt9+xdA Date: Mon, 23 Jun 2014 02:29:36 +0000 Message-ID: References: <1403244889-21358-1-git-send-email-helin.zhang@intel.com> <1403244889-21358-3-git-send-email-helin.zhang@intel.com> <6265238.1xJbmmqJzt@xps13> In-Reply-To: <6265238.1xJbmmqJzt@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/7] i40evf: support configuring crc stripping hw offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jun 2014 02:29:23 -0000 -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Friday, June 20, 2014 10:08 PM To: Zhang, Helin Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/7] i40evf: support configuring crc strippi= ng hw offload Hi Helin, 2014-06-20 14:14, Helin Zhang: > In VF driver, crc stripping hw offload is enabled or not, according to=20 > the configurations in config file. >=20 > Signed-off-by: Helin Zhang > Acked-by: Cunming Liang > Acked-by: Jing Chen [...] > static int > -i40evf_dev_configure(__rte_unused struct rte_eth_dev *dev) > +i40evf_dev_configure(struct rte_eth_dev *dev) > { > + struct rte_eth_conf* conf =3D &dev->data->dev_conf; > + > +#ifdef RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC > + if (conf->rxmode.hw_strip_crc) { > + conf->rxmode.hw_strip_crc =3D 0; > + PMD_DRV_LOG(INFO, "VF can not enable hw CRC stripping\n"); > + } > +#else > + if (!conf->rxmode.hw_strip_crc) { > + conf->rxmode.hw_strip_crc =3D 1; > + PMD_DRV_LOG(INFO, "VF can not disable hw CRC stripping\n"); }=20 > +#endif > + > return 0; > } Please, I don't understand why CRC stripping must be configured at build ti= me. I understand VF capability depends of the PF configuration, but we should b= e able to configure it at run time. -- Thomas ---------------------------------------------------------------------------= ------------------------------------------------------------- Hi Thomas This solution is the same as what we did in ixgbe. As you know most of VF f= unctionalities are controlled by PF. If the configuration is set for global, VF driver cannot ask for change, as= the change will impact PF functionality. If the configuration can be set for PF/VF function separately, VF driver ca= n change it directly or ask PF to change according to the hardware implemen= tation. Let's skip the VF CRC change for i40e of 1.7.0-rc2 at this moment, and I wi= ll investigate more and send separate patches later for that. Regards, Helin