From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 34F1D5930 for ; Thu, 24 Jul 2014 10:13:10 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 24 Jul 2014 01:14:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,722,1400050800"; d="scan'208";a="574670842" Received: from fmsmsx104.amr.corp.intel.com ([10.19.9.35]) by fmsmga002.fm.intel.com with ESMTP; 24 Jul 2014 01:14:36 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.19.17.220) by FMSMSX104.amr.corp.intel.com (10.19.9.35) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 24 Jul 2014 01:14:35 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX151.amr.corp.intel.com (10.19.17.220) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 24 Jul 2014 01:14:35 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.204]) by shsmsx102.ccr.corp.intel.com ([169.254.2.120]) with mapi id 14.03.0123.003; Thu, 24 Jul 2014 16:14:34 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet classification type Thread-Index: AQHPpxO7hZbuZpxe6Uy2+vEfk1yc85uu3+ng Date: Thu, 24 Jul 2014 08:14:32 +0000 Message-ID: References: <1406184149-11531-1-git-send-email-helin.zhang@intel.com> <1406184149-11531-2-git-send-email-helin.zhang@intel.com> <2490690.EmSZ5vBN3i@xps13> In-Reply-To: <2490690.EmSZ5vBN3i@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet classification type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2014 08:13:10 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, July 24, 2014 3:48 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet > classification type >=20 > Hi Helin, >=20 > 2014-07-24 14:42, Helin Zhang: > > For better understanding, 'PCTYPE' was added to the name of i40e RSS > > shift macros. > > > > Signed-off-by: Helin Zhang >=20 > > -#define ETH_RSS_NONF_IPV4_UDP_SHIFT 31 > > +#define ETH_PCTYPE_NONF_IPV4_UDP 31 >=20 > Why is it clearer? I don't understand what means PCTYPE. >=20 > -- > Thomas Hi Thomas It is 'packet classification type' defined in data sheet, and widely used. = It is not just for RSS only, it can be used for flow director possibly. Tha= t's why I think it would be better to rename it with PCTYPE names. Thank yo= u! Regards, Helin