From: "Zhang, Helin" <helin.zhang@intel.com>
To: Aaro Koskinen <aaro.koskinen@nsn.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] kni: fix build with Linux 3.17
Date: Tue, 19 Aug 2014 02:55:31 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A77F362@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1408365899-29179-1-git-send-email-aaro.koskinen@nsn.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Aaro Koskinen
> Sent: Monday, August 18, 2014 8:45 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] kni: fix build with Linux 3.17
>
> In the series of ever-lasting ugly #ifdefs trying make out-of-tree drivers to
> support latest mainline kernel...
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>
> ---
> lib/librte_eal/linuxapp/kni/kni_misc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c
> b/lib/librte_eal/linuxapp/kni/kni_misc.c
> index 1c085d9..ba77776 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_misc.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
> @@ -345,6 +345,9 @@ kni_ioctl_create(unsigned int ioctl_num, unsigned long
> ioctl_param)
> up_read(&kni_list_lock);
>
> net_dev = alloc_netdev(sizeof(struct kni_dev), dev_info.name,
> +#ifdef NET_NAME_UNKNOWN
> + NET_NAME_UNKNOWN,
> +#endif
> kni_net_init);
> if (net_dev == NULL) {
> KNI_ERR("error allocating device \"%s\"\n", dev_info.name);
> --
> 2.0.0
Will this interface be changed from kernel version 3.17?
Would it be better to add kernel version check here instead?
Regards,
Helin
next prev parent reply other threads:[~2014-08-19 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 12:44 Aaro Koskinen
2014-08-19 2:55 ` Zhang, Helin [this message]
2014-08-29 14:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A77F362@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=aaro.koskinen@nsn.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).