From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Liu, Jijiang" <jijiang.liu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
Date: Wed, 15 Oct 2014 06:54:50 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A79C5EF@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1413342878-18584-1-git-send-email-jijiang.liu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> Sent: Wednesday, October 15, 2014 11:15 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
>
> This patch adds incoming packet error statistics in the i40e_ethdev.c file.
>
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> ---
> lib/librte_pmd_i40e/i40e_ethdev.c | 11 +++++++++--
> 1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index 46c43a7..dbf231f 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -1274,6 +1274,9 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
>
> pf->offset_loaded = true;
>
> + if (pf->main_vsi)
> + i40e_update_vsi_stats(pf->main_vsi);
> +
> stats->ipackets = ns->eth.rx_unicast + ns->eth.rx_multicast +
> ns->eth.rx_broadcast;
> stats->opackets = ns->eth.tx_unicast + ns->eth.tx_multicast + @@
> -1283,8 +1286,12 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
> stats->oerrors = ns->eth.tx_errors;
> stats->imcasts = ns->eth.rx_multicast;
>
> - if (pf->main_vsi)
> - i40e_update_vsi_stats(pf->main_vsi);
> + /* Rx Errors */
> + stats->ibadcrc = ns->crc_errors;
> + stats->ibadlen = ns->rx_length_errors + ns->rx_undersize +
> + ns->rx_oversize + ns->rx_fragments + ns->rx_jabber;
> + stats->imissed = ns->eth.rx_discards;
> + stats->ierrors = stats->ibadcrc + stats->ibadlen + stats->imissed;
>
> PMD_DRV_LOG(DEBUG, "***************** PF stats start
> *******************");
> PMD_DRV_LOG(DEBUG, "rx_bytes: %lu",
> ns->eth.rx_bytes);
> --
> 1.7.7.6
next prev parent reply other threads:[~2014-10-15 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 3:14 Jijiang Liu
2014-10-15 6:54 ` Zhang, Helin [this message]
2014-10-15 12:21 ` Thomas Monjalon
2014-10-16 0:55 ` Zhang, Helin
2014-10-15 12:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A79C5EF@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).